Revert of Revert "Typecheck JS files for chrome://extensions"

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="extension_code.js">
 <include src="extension_commands_overlay.js">
+<include src="extension_error_overlay.js">
 <include src="extension_focus_manager.js">
 <include src="extension_list.js">
 <include src="pack_extension_overlay.js">
-<include src="extension_error_overlay.js">
 <include src="extension_loader.js">
 <include src="extension_options_overlay.js">
 
 <if expr="chromeos">
 <include src="chromeos/kiosk_apps.js">
 </if>
 
+/**
+ * The type of the extension data object. The definition is based on
+ * chrome/browser/ui/webui/extensions/extension_settings_handler.cc:
+ *     ExtensionSettingsHandler::HandleRequestExtensionsData()
+ * @typedef {{developerMode: boolean,
+ *            extensions: Array,
+ *            incognitoAvailable: boolean,
+ *            loadUnpackedDisabled: boolean,
+ *            profileIsSupervised: boolean,
+ *            promoteAppsDevTools: boolean}}
+ */
+var ExtensionDataResponse;
+
 // Used for observing function of the backend datasource for this page by
 // tests.
 var webuiResponded = false;
 
 cr.define('extensions', function() {
   var ExtensionsList = options.ExtensionsList;
 
   // Implements the DragWrapper handler interface.
   var dragWrapperHandler = {
     /** @override */
@@ skipping 223 matching lines @@
      */
     handleToggleDevMode_: function(e) {
       if ($('toggle-dev-on').checked) {
         $('dev-controls').hidden = false;
         window.setTimeout(function() {
           $('extension-settings').classList.add('dev-mode');
         }, 0);
       } else {
         $('extension-settings').classList.remove('dev-mode');
       }
-      window.setTimeout(this.updatePromoVisibility_.bind(this));
+      window.setTimeout(this.updatePromoVisibility_.bind(this), 0);
 
       chrome.send('extensionSettingsToggleDeveloperMode');
     },
 
     /**
      * Called when a transition has ended for #dev-controls.
      * @param {Event} e webkitTransitionEnd event.
      * @private
      */
     handleDevControlsTransitionEnd_: function(e) {
       if (e.propertyName == 'height' &&
           !$('extension-settings').classList.contains('dev-mode')) {
         $('dev-controls').hidden = true;
       }
     },
   };
 
   /**
    * Called by the dom_ui_ to re-populate the page with data representing
    * the current state of installed extensions.
+   * @param {ExtensionDataResponse} extensionsData
    */
   ExtensionSettings.returnExtensionsData = function(extensionsData) {
     // We can get called many times in short order, thus we need to
     // be careful to remove the 'finished loading' timeout.
     if (this.loadingTimeout_)
       window.clearTimeout(this.loadingTimeout_);
     document.documentElement.classList.add('loading');
     this.loadingTimeout_ = window.setTimeout(function() {
       document.documentElement.classList.remove('loading');
     }, 0);
@@ skipping 103 matching lines @@
       currentlyShowingOverlay.classList.remove('showing');
 
     if (node)
       node.classList.add('showing');
 
     var pages = document.querySelectorAll('.page');
     for (var i = 0; i < pages.length; i++) {
       pages[i].setAttribute('aria-hidden', node ? 'true' : 'false');
     }
 
-    overlay.hidden = !node;
+    $('overlay').hidden = !node;
     uber.invokeMethodOnParent(node ? 'beginInterceptingEvents' :
                                      'stopInterceptingEvents');
   };
 
   /**
    * Utility function to find the width of various UI strings and synchronize
    * the width of relevant spans. This is crucial for making sure the
    * Enable/Enabled checkboxes align, as well as the Developer Mode checkbox.
    */
   function measureCheckboxStrings() {
@@ skipping 23 matching lines @@
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   extensions.ExtensionSettings.getInstance().initialize();
 });