Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 512002: Workaround bug in Pango that was resulted in incorrect wrapping.... (Closed)

Created:
11 years ago by sky
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Workaround bug in Pango that was resulted in incorrect wrapping. BUG=30361 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M app/gfx/canvas_linux.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
11 years ago (2009-12-22 23:27:36 UTC) #1
DaveMoore
LGTM It's hard to believe this bug is in there, but if we have to ...
11 years ago (2009-12-23 00:28:28 UTC) #2
sky
This was bugging me a bit, so I stepped into Pango to figure out what ...
10 years, 11 months ago (2010-01-04 23:40:04 UTC) #3
Evan Martin
I wonder if it's the difference between the ink rect and the logical rect?
10 years, 11 months ago (2010-01-05 00:55:17 UTC) #4
sky
10 years, 11 months ago (2010-01-05 00:58:33 UTC) #5
I tried and that isn't it. I believe it's as I said, the size of
whitespace is used when breaking, but is not reported in the logical
rect.

  -Scott

On Mon, Jan 4, 2010 at 4:55 PM,  <evan@chromium.org> wrote:
> I wonder if it's the difference between the ink rect and the logical rect?
>
> http://codereview.chromium.org/512002
>

Powered by Google App Engine
This is Rietveld 408576698