Issue 511993005: sandbox: style cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511993005: sandbox: style cleanup (Closed)

Created:
6 years, 3 months ago by mdempsky

Modified:
6 years, 3 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

sandbox: style cleanup Based on readability review by Dean Berris at Google. R=jln@chromium.org Committed: https://crrev.com/62964a694ce67c5425344e2b6473724808a93f74 Cr-Commit-Position: refs/heads/master@{#292698}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -52 lines)			Patch
M	sandbox/linux/bpf_dsl/bpf_dsl.h	View	5 chunks	+29 lines, -14 lines	0 comments	Download
M	sandbox/linux/bpf_dsl/bpf_dsl.cc	View	10 chunks	+65 lines, -36 lines	0 comments	Download
M	sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

mdempsky

mdempsky@chromium.org changed reviewers: + jln@chromium.org

6 years, 3 months ago (2014-08-28 18:00:26 UTC) #1

mdempsky

Same as patch set 8 from the readability review, except without the unnecessary codereview.settings and ...

6 years, 3 months ago (2014-08-28 18:00:26 UTC) #2

mdempsky

Committed patchset #1 (id:1) manually as 62964a6 (presubmit successful).

6 years, 3 months ago (2014-08-29 23:10:14 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:11:01 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/62964a694ce67c5425344e2b6473724808a93f74
Cr-Commit-Position: refs/heads/master@{#292698}