Rearrange tables so that navigation can be added back to certain pages.

Rearrange tables so that navigation can be added back to certain pages.

BUG=none
R= mkearney@chromium.org, smain@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Committed: https://crrev.com/0ad1d41b78f8c4ffd37137abf1927ce59298d62a
Cr-Commit-Position: refs/heads/master@{#295114}

[jpmedley, 2014-08-28 00:52:26]

jmedley@chromium.org changed reviewers:
+ mkearney@google.com, smain@chromium.org

[jpmedley, 2014-09-05 20:28:01]

I may have misinterpreted how Chromium notifies reviewers. Have either of you
seen this before?

[native-client-reviews_googlegroups.com, 2014-09-05 21:23:56]

Not sure--

Did you press the publish button?

Meggin


On Fri, Sep 5, 2014 at 1:28 PM, <jmedley@chromium.org> wrote:

> Reviewers: mkearney, smain,
>
> Message:
> I may have misinterpreted how Chromium notifies reviewers. Have either of
> you
> seen this before?
>
> Description:
> Rearrange tables so that navigation can be added back to certain pages.
>
> BUG=none
> R= mkearney@chromium.org, smain@chromium.org
> TEST=none
> NOTRY=true
> (documentation only change)
>
> Please review this at https://codereview.chromium.org/511963004/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+470, -531 lines):
>   M native_client_sdk/doc_generated/devguide/coding/progress-events.html
>   M native_client_sdk/doc_generated/devguide/coding/
> view-focus-input-events.html
>   M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html
>   M native_client_sdk/doc_generated/devguide/devcycle/running.html
>   M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html
>   M native_client_sdk/doc_generated/devguide/distributing.html
>   M native_client_sdk/doc_generated/sitemap.html
>   M native_client_sdk/src/doc/devguide/coding/progress-events.rst
>   M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst
>   M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst
>   M native_client_sdk/src/doc/devguide/devcycle/running.rst
>   M native_client_sdk/src/doc/devguide/devcycle/vs-addin.rst
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[chromium-reviews, 2014-09-05 21:23:57]

Not sure--

Did you press the publish button?

Meggin


On Fri, Sep 5, 2014 at 1:28 PM, <jmedley@chromium.org> wrote:

> Reviewers: mkearney, smain,
>
> Message:
> I may have misinterpreted how Chromium notifies reviewers. Have either of
> you
> seen this before?
>
> Description:
> Rearrange tables so that navigation can be added back to certain pages.
>
> BUG=none
> R= mkearney@chromium.org, smain@chromium.org
> TEST=none
> NOTRY=true
> (documentation only change)
>
> Please review this at https://codereview.chromium.org/511963004/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+470, -531 lines):
>   M native_client_sdk/doc_generated/devguide/coding/progress-events.html
>   M native_client_sdk/doc_generated/devguide/coding/
> view-focus-input-events.html
>   M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html
>   M native_client_sdk/doc_generated/devguide/devcycle/running.html
>   M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html
>   M native_client_sdk/doc_generated/devguide/distributing.html
>   M native_client_sdk/doc_generated/sitemap.html
>   M native_client_sdk/src/doc/devguide/coding/progress-events.rst
>   M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst
>   M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst
>   M native_client_sdk/src/doc/devguide/devcycle/running.rst
>   M native_client_sdk/src/doc/devguide/devcycle/vs-addin.rst
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[native-client-reviews_googlegroups.com, 2014-09-05 21:26:33]

I did something else I thought was the same thing, but wasn't. Water under
the bridge.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Fri, Sep 5, 2014 at 3:23 PM, Meggin Kearney <mkearney@google.com> wrote:

> Not sure--
>
> Did you press the publish button?
>
> Meggin
>
>
> On Fri, Sep 5, 2014 at 1:28 PM, <jmedley@chromium.org> wrote:
>
>> Reviewers: mkearney, smain,
>>
>> Message:
>> I may have misinterpreted how Chromium notifies reviewers. Have either of
>> you
>> seen this before?
>>
>> Description:
>> Rearrange tables so that navigation can be added back to certain pages.
>>
>> BUG=none
>> R= mkearney@chromium.org, smain@chromium.org
>> TEST=none
>> NOTRY=true
>> (documentation only change)
>>
>> Please review this at https://codereview.chromium.org/511963004/
>>
>> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+470, -531 lines):
>>   M native_client_sdk/doc_generated/devguide/coding/progress-events.html
>>   M native_client_sdk/doc_generated/devguide/coding/
>> view-focus-input-events.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/
>> dynamic-loading.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/running.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html
>>   M native_client_sdk/doc_generated/devguide/distributing.html
>>   M native_client_sdk/doc_generated/sitemap.html
>>   M native_client_sdk/src/doc/devguide/coding/progress-events.rst
>>   M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/running.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/vs-addin.rst
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[chromium-reviews, 2014-09-05 21:26:33]

I did something else I thought was the same thing, but wasn't. Water under
the bridge.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Fri, Sep 5, 2014 at 3:23 PM, Meggin Kearney <mkearney@google.com> wrote:

> Not sure--
>
> Did you press the publish button?
>
> Meggin
>
>
> On Fri, Sep 5, 2014 at 1:28 PM, <jmedley@chromium.org> wrote:
>
>> Reviewers: mkearney, smain,
>>
>> Message:
>> I may have misinterpreted how Chromium notifies reviewers. Have either of
>> you
>> seen this before?
>>
>> Description:
>> Rearrange tables so that navigation can be added back to certain pages.
>>
>> BUG=none
>> R= mkearney@chromium.org, smain@chromium.org
>> TEST=none
>> NOTRY=true
>> (documentation only change)
>>
>> Please review this at https://codereview.chromium.org/511963004/
>>
>> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+470, -531 lines):
>>   M native_client_sdk/doc_generated/devguide/coding/progress-events.html
>>   M native_client_sdk/doc_generated/devguide/coding/
>> view-focus-input-events.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/
>> dynamic-loading.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/running.html
>>   M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html
>>   M native_client_sdk/doc_generated/devguide/distributing.html
>>   M native_client_sdk/doc_generated/sitemap.html
>>   M native_client_sdk/src/doc/devguide/coding/progress-events.rst
>>   M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/running.rst
>>   M native_client_sdk/src/doc/devguide/devcycle/vs-addin.rst
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jpmedley, 2014-09-10 21:15:16]

Have you had a chance to look at this?

[mkearney1, 2014-09-10 21:29:00]

On 2014/09/10 21:15:16, jmedley wrote:
> Have you had a chance to look at this?

Not yet-- can you send a staged version? Just like to check UI and source files.
Thanks.

[mkearney1, 2014-09-12 23:40:34]

mkearney@chromium.org changed reviewers:
+ mkearney@chromium.org

[mkearney1, 2014-09-12 23:40:34]

lgtm with just a few nits (adding periods to descriptions). Nice one.

https://codereview.chromium.org/511963004/diff/20001/native_client_sdk/doc_ge...
File native_client_sdk/doc_generated/devguide/coding/progress-events.html
(right):

https://codereview.chromium.org/511963004/diff/20001/native_client_sdk/doc_ge...
native_client_sdk/doc_generated/devguide/coding/progress-events.html:135: will
want to</td>
Small nit- add period after 'to'.

https://codereview.chromium.org/511963004/diff/20001/native_client_sdk/doc_ge...
File native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html
(right):

https://codereview.chromium.org/511963004/diff/20001/native_client_sdk/doc_ge...
native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html:44:
<dd>The GNU implementation of the <a class="reference external"
href="http://en.wikipedia.org/wiki/POSIX">POSIX</a> standard
Small nit-- add period at the end of library description.

https://codereview.chromium.org/511963004/diff/20001/native_client_sdk/doc_ge...
native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html:71: about
newlib, see <a class="reference external"
href="http://sourceware.org/newlib/">newlib</a></dd>
Small nit-- add period at the end of library description.

[jpmedley, 2014-09-15 14:50:44]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-09-15 14:51:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/511963004/80001

[commit-bot: I haz the power, 2014-09-15 14:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 14:51:05]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jpmedley, 2014-09-15 14:55:02]

For some reason, the system does not like your LGTM.

[Sam Clegg, 2014-09-15 17:08:37]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2014-09-15 17:08:38]

lgtm

[binji, 2014-09-15 17:10:21]

binji@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-09-15 17:10:22]

lgtm

[jpmedley, 2014-09-16 19:00:32]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:01:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/511963004/80001

[commit-bot: I haz the power, 2014-09-16 19:03:28]

Committed patchset #5 (id:80001) as 79006f1adc8fa13c6d2ffeeb331528b0774d3bdb

[commit-bot: I haz the power, 2014-09-16 19:04:32]

Patchset 5 (id:??) landed as
https://crrev.com/0ad1d41b78f8c4ffd37137abf1927ce59298d62a
Cr-Commit-Position: refs/heads/master@{#295114}