Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6234)

Unified Diff: chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js

Issue 511943004: Don't set lastError if chrome.dial.discoverNow() can't start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to Wez' comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
diff --git a/chrome/test/data/extensions/api_test/dial/experimental/discovery.js b/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
similarity index 58%
copy from chrome/test/data/extensions/api_test/dial/experimental/discovery.js
copy to chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
index 917462c41ce488ca7ee30b460dc56aa49047dba2..b0ad2aeb619fa1d4e176fdd5038cf5f1a11ef11d 100644
--- a/chrome/test/data/extensions/api_test/dial/experimental/discovery.js
+++ b/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
@@ -4,15 +4,17 @@
onload = function() {
chrome.test.runTests([
- function discovery() {
- var discoverNowShouldFail = function(result) {
+ function discoverNowWithoutListeners() {
+ var discoverNowCallback = function(result) {
+ chrome.test.assertNoLastError();
+ chrome.test.assertTrue(typeof(result) == 'boolean');
if (!result) {
chrome.test.succeed();
} else {
chrome.test.fail();
}
};
- chrome.dial.discoverNow(discoverNowShouldFail);
+ chrome.dial.discoverNow(discoverNowCallback);
}
]);
};
« no previous file with comments | « chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698