Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 511943002: Make the password manager python tests a module (Closed)

Created:
6 years, 3 months ago by rchtara
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the password manager python tests a module. Add __init__.py file to the password manager python tests to make it a module so that it could be imported from python files in the parent folder. BUG=408198 Committed: https://crrev.com/24dcd28998eee1d37c67ccb680a654a9dc8e341d Cr-Commit-Position: refs/heads/master@{#292357}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
A + components/test/data/password_manager/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
rchtara
rchtara@chromium.org changed reviewers: + rchtara@chromium.org
6 years, 3 months ago (2014-08-27 17:26:26 UTC) #1
rchtara
rchtara@chromium.org changed reviewers: + vabr@chromium.org - rchtara@chromium.org
6 years, 3 months ago (2014-08-27 17:33:01 UTC) #2
rchtara
Hi, Could you please review this cl? Thanks a lot Riadh
6 years, 3 months ago (2014-08-28 07:41:38 UTC) #3
vabr (Chromium)
Thanks, Riadh, LGTM. But before you land, could you please re-upload this using git cl ...
6 years, 3 months ago (2014-08-28 08:32:13 UTC) #4
rchtara
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-28 08:38:40 UTC) #5
rchtara
Patchset #2 (id:40001) has been deleted
6 years, 3 months ago (2014-08-28 08:38:49 UTC) #6
rchtara
I did git cl upload --similarity=100. A new patch was created but the new file ...
6 years, 3 months ago (2014-08-28 08:44:48 UTC) #7
vabr (Chromium)
On 2014/08/28 08:44:48, rchtara wrote: > I did git cl upload --similarity=100. > A new ...
6 years, 3 months ago (2014-08-28 09:16:43 UTC) #8
rchtara
The CQ bit was checked by rchtara@chromium.org
6 years, 3 months ago (2014-08-28 09:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchtara@chromium.org/511943002/60001
6 years, 3 months ago (2014-08-28 09:18:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 5cfa42a90107ab768360f7544629a279f8fd25ce
6 years, 3 months ago (2014-08-28 10:13:27 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24dcd28998eee1d37c67ccb680a654a9dc8e341d
Cr-Commit-Position: refs/heads/master@{#292357}

Powered by Google App Engine
This is Rietveld 408576698