Move 'Extensions' to the main menu for settings-in-a-window

Move 'Extensions' to the main menu for settings-in-a-window

BUG=407162
Committed: https://crrev.com/9dc76456d19bc4c1ada2c28cf0cc74911cc74581
Cr-Commit-Position: refs/heads/master@{#292492}

[stevenjb, 2014-08-27 16:13:28]

stevenjb@chromium.org changed reviewers:
+ estade@chromium.org, sky@chromium.org

[stevenjb, 2014-08-27 16:13:28]

This currently only affects Chrome OS by default, see issue for details.

[sky, 2014-08-27 16:30:45]

No idea what settings-in-a-window, but ok. LGTM

[stevenjb, 2014-08-27 16:54:02]

On 2014/08/27 16:30:45, sky wrote:
> No idea what settings-in-a-window, but ok. LGTM

(FYI: It's basically what it sounds like, we show Settings in a separate Window
instead of in a tab, with no History/Extensions/About sidebar links. 'About' has
been integrated into the Settings page. We may do the same for the 'Extensions'
link, but for now we decided to make it a top-level menu item to improve
discoverability).

[Evan Stade, 2014-08-28 18:13:51]

lgtm

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:253: // If settins-in-a-window is
enabled, the Extensions item is at the top level.
nit: spelling

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:618: // If settins-in-a-window is
enabled, the Extensions item is at the top level.
spelling again

[stevenjb, 2014-08-28 19:50:00]

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:253: // If settins-in-a-window is
enabled, the Extensions item is at the top level.
On 2014/08/28 18:13:51, Evan Stade wrote:
> nit: spelling

Done.

https://codereview.chromium.org/511923002/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:618: // If settins-in-a-window is
enabled, the Extensions item is at the top level.
On 2014/08/28 18:13:51, Evan Stade wrote:
> spelling again

Done.

[stevenjb, 2014-08-28 19:50:04]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-08-28 19:51:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/511923002/20001

[commit-bot: I haz the power, 2014-08-28 21:12:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 23:25:30]

Committed patchset #2 (id:20001) as c824f85a3c2754c5afefc1b7db1506136a7df593

[commit-bot: I haz the power, 2014-09-10 03:03:18]

Patchset 2 (id:??) landed as
https://crrev.com/9dc76456d19bc4c1ada2c28cf0cc74911cc74581
Cr-Commit-Position: refs/heads/master@{#292492}