Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 511903003: Use precisely sized integer types in histograms code. (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use precisely sized integer types in histograms code. BUG=none TEST=none R=asvitkine@chromium.org Committed: https://crrev.com/bed49a668bf2d496416ae7346d7d3a1f42e44260 Cr-Commit-Position: refs/heads/master@{#292340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M base/metrics/histogram_base.h View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
I'm pretty sure that this is equivalent to the existing code, but more explicit. WDYT?
6 years, 3 months ago (2014-08-27 22:45:12 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-08-28 04:38:21 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 3 months ago (2014-08-28 05:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/511903003/1
6 years, 3 months ago (2014-08-28 05:16:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 06:29:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 31bd6e7ec6e380a5a1b3abcbb063e6768496416d
6 years, 3 months ago (2014-08-28 07:22:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bed49a668bf2d496416ae7346d7d3a1f42e44260
Cr-Commit-Position: refs/heads/master@{#292340}

Powered by Google App Engine
This is Rietveld 408576698