Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 511873002: DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/devtools_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent.cc
diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc
index 7cf467615263c8695db194c2664063da1489420d..71f55bbd3cdba7ab84cb3cf700fab4b258b7fdb0 100644
--- a/content/renderer/devtools/devtools_agent.cc
+++ b/content/renderer/devtools/devtools_agent.cc
@@ -171,6 +171,7 @@ void DevToolsAgent::setTraceEventCallback(const WebString& category_filter,
}
void DevToolsAgent::enableTracing(const WebString& category_filter) {
+ Send(new DevToolsHostMsg_EnableTracing(routing_id(), category_filter.utf8()));
TraceLog* trace_log = TraceLog::GetInstance();
trace_log->SetEnabled(base::debug::CategoryFilter(category_filter.utf8()),
TraceLog::RECORDING_MODE,
@@ -179,6 +180,7 @@ void DevToolsAgent::enableTracing(const WebString& category_filter) {
void DevToolsAgent::disableTracing() {
TraceLog::GetInstance()->SetDisabled();
+ Send(new DevToolsHostMsg_DisableTracing(routing_id()));
}
// static
« no previous file with comments | « content/common/devtools_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698