content/browser/devtools/devtools_tracing_handler.h - Issue 511873002: DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 511873002: DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed category filter Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_protocol.cc ('k') | content/browser/devtools/devtools_tracing_handler.cc » ('j') | content/browser/devtools/devtools_tracing_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_tracing_handler.h

diff --git a/content/browser/devtools/devtools_tracing_handler.h b/content/browser/devtools/devtools_tracing_handler.h

index 20ebca8685022abc8990a45898fafbf50c6e5412..fe270bd847264bd4eb3283885a8cf0bce90af6ae 100644

--- a/content/browser/devtools/devtools_tracing_handler.h

+++ b/content/browser/devtools/devtools_tracing_handler.h

@@ -30,6 +30,9 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {

void OnClientDetached();

+ void EnableTracing(const std::string& category_filter);

+ void DisableTracing();

private:

void BeginReadingRecordingResult(const base::FilePath& path);

void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result);

@@ -45,12 +48,6 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {

scoped_refptr<DevToolsProtocol::Response> OnGetCategories(

scoped_refptr<DevToolsProtocol::Command> command);

- void OnTracingStarted(

- scoped_refptr<DevToolsProtocol::Notification> notification);

- void OnTracingStopped(

- scoped_refptr<DevToolsProtocol::Notification> notification);

void OnCategoriesReceived(scoped_refptr<DevToolsProtocol::Command> command,

const std::set<std::string>& category_set);