Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 511863002: Mac Video Capture: Connect AVFoundation for Canary and Developer builds. Other channels unaffected. (Closed)

Created:
6 years, 3 months ago by mcasas
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac Video Capture: Connect AVFoundation for Canary and Developer builds. Other channels unaffected. BUG=408089 Committed: https://crrev.com/6a35b2b82305427017f42a971dc022d154eb127d Cr-Commit-Position: refs/heads/master@{#292161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mcasas
mcasas@chromium.org changed reviewers: + tommi@chromium.org, vrk@chromium.org
6 years, 3 months ago (2014-08-27 13:18:08 UTC) #1
mcasas
tommi@ and/or vrk@ OWNERS RS/ PTAL
6 years, 3 months ago (2014-08-27 13:18:08 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-08-27 13:29:37 UTC) #3
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 3 months ago (2014-08-27 13:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/511863002/1
6 years, 3 months ago (2014-08-27 13:38:02 UTC) #5
tommi (sloooow) - chröme
The CQ bit was unchecked by tommi@chromium.org
6 years, 3 months ago (2014-08-27 13:53:09 UTC) #6
tommi (sloooow) - chröme
I stopped the CQ. Can you change this to be Canary only for now? Since ...
6 years, 3 months ago (2014-08-27 13:54:04 UTC) #7
mcasas
On 2014/08/27 13:54:04, tommi wrote: > I stopped the CQ. Can you change this to ...
6 years, 3 months ago (2014-08-27 13:58:47 UTC) #8
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 3 months ago (2014-08-27 13:58:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/511863002/1
6 years, 3 months ago (2014-08-27 14:00:05 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 15:24:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as d5eb3b7a17bbb855d1afefdf7ddd229f57537ac7
6 years, 3 months ago (2014-08-27 15:58:52 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a35b2b82305427017f42a971dc022d154eb127d
Cr-Commit-Position: refs/heads/master@{#292161}

Powered by Google App Engine
This is Rietveld 408576698