Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 511803002: Fix chromium update in auto-roller. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Ryan Tseng, Jarin, hinoka
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix chromium update in auto-roller. BUG= R=hinoka@google.com Committed: https://code.google.com/p/v8/source/detail?r=23455

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/push-to-trunk/chromium_roll.py View 1 chunk +6 lines, -0 lines 1 comment Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
machenbach@chromium.org changed reviewers: + hinoka@chromium.org, jarin@chromium.org
6 years, 3 months ago (2014-08-27 10:10:53 UTC) #1
Michael Achenbach
PTAL. When I said "it's the last CL" in my last CL... well never mind. ...
6 years, 3 months ago (2014-08-27 10:10:53 UTC) #2
Ryan Tseng
hinoka@google.com changed reviewers: + hinoka@google.com
6 years, 3 months ago (2014-08-27 10:19:44 UTC) #3
Ryan Tseng
https://codereview.chromium.org/511803002/diff/1/tools/push-to-trunk/chromium_roll.py File tools/push-to-trunk/chromium_roll.py (right): https://codereview.chromium.org/511803002/diff/1/tools/push-to-trunk/chromium_roll.py#newcode79 tools/push-to-trunk/chromium_roll.py:79: self.GitFetchOrigin() This is going to run into the same ...
6 years, 3 months ago (2014-08-27 10:19:44 UTC) #4
Ryan Tseng
talked offline, i see the problem - because we want to find revisions AFTER the ...
6 years, 3 months ago (2014-08-27 12:07:08 UTC) #5
Michael Achenbach
6 years, 3 months ago (2014-08-27 13:13:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as 23455 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698