SkTextBlob GPipe serialization.

SkTextBlob GPipe serialization.

Instead of relying on unrolling blobs in SkCanvas, serialize when
passing through a GPipe.

This is a prerequisite for pushing the blob draw op to the device.

R=reed@google.com,mtklein@google.com,robertphillips@google.com

Committed: https://skia.googlesource.com/skia/+/228a6f275d7c5c17c48c20b57df971d9848f5dff

[mtklein, 2014-08-28 18:53:27]

https://codereview.chromium.org/511783005/diff/1/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/511783005/diff/1/include/core/SkTextBlob.h#ne...
include/core/SkTextBlob.h:41: *  Recreate a picture that was serialized into a
buffer.
picture -> SkTextBlob ?

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:682: SkReadBuffer blobBuffer(data, blobSize);
This seems like a small thing, but I bet we could condition the creation of the
SkReadBuffer and call to CreateFromBuffer() on state->shouldDraw().

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:684: 
Consider SkASSERT(blob.get()) ?

[f(malita), 2014-08-28 19:02:45]

https://codereview.chromium.org/511783005/diff/1/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/511783005/diff/1/include/core/SkTextBlob.h#ne...
include/core/SkTextBlob.h:41: *  Recreate a picture that was serialized into a
buffer.
On 2014/08/28 18:53:27, mtklein wrote:
> picture -> SkTextBlob ?

Doh. Done.

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:682: SkReadBuffer blobBuffer(data, blobSize);
On 2014/08/28 18:53:27, mtklein wrote:
> This seems like a small thing, but I bet we could condition the creation of
the
> SkReadBuffer and call to CreateFromBuffer() on state->shouldDraw().

Done.

https://codereview.chromium.org/511783005/diff/1/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:684: 
On 2014/08/28 18:53:27, mtklein wrote:
> Consider SkASSERT(blob.get()) ?

Done.

[mtklein, 2014-08-28 19:04:50]

lgtm

[f(malita), 2014-08-28 20:00:21]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-08-28 20:00:40]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/511783005/20001

[commit-bot: I haz the power, 2014-08-28 20:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 20:00:45]

Presubmit check for 511783005-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[reed1, 2014-08-28 20:44:30]

lgtm

[f(malita), 2014-08-28 20:44:48]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-08-28 20:45:50]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/511783005/20001

[commit-bot: I haz the power, 2014-08-28 20:59:46]

Committed patchset #2 (id:20001) as 228a6f275d7c5c17c48c20b57df971d9848f5dff