Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 511783003: Fix error handling in DirectWrite with tiny text. (Closed)

Created:
6 years, 3 months ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix error handling in DirectWrite with tiny text. If there is an error while trying to determine the metrics, we need to bail instead of potentially using uninitialized data. Committed: https://skia.googlesource.com/skia/+/683a37692bc67ef1144922b73a1e871e7e1e842e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clarify code flow, guard against backward RECTs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -37 lines) Patch
M src/ports/SkScalerContext_win_dw.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 1 2 chunks +53 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bungeman-skia
bungeman@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-28 17:04:17 UTC) #1
bungeman-skia
6 years, 3 months ago (2014-08-28 17:04:17 UTC) #2
bungeman-skia
bungeman@google.com changed reviewers: + mtklein@google.com
6 years, 3 months ago (2014-08-28 17:19:57 UTC) #3
bungeman-skia
6 years, 3 months ago (2014-08-28 17:19:57 UTC) #4
mtklein
https://codereview.chromium.org/511783003/diff/1/src/ports/SkScalerContext_win_dw.cpp File src/ports/SkScalerContext_win_dw.cpp (right): https://codereview.chromium.org/511783003/diff/1/src/ports/SkScalerContext_win_dw.cpp#newcode477 src/ports/SkScalerContext_win_dw.cpp:477: if (bbox.left == bbox.right || bbox.top == bbox.bottom) { ...
6 years, 3 months ago (2014-08-28 17:25:50 UTC) #5
bungeman-skia
ptal https://codereview.chromium.org/511783003/diff/1/src/ports/SkScalerContext_win_dw.cpp File src/ports/SkScalerContext_win_dw.cpp (right): https://codereview.chromium.org/511783003/diff/1/src/ports/SkScalerContext_win_dw.cpp#newcode477 src/ports/SkScalerContext_win_dw.cpp:477: if (bbox.left == bbox.right || bbox.top == bbox.bottom) ...
6 years, 3 months ago (2014-08-28 18:01:04 UTC) #6
mtklein
lgtm
6 years, 3 months ago (2014-08-28 18:33:52 UTC) #7
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 3 months ago (2014-08-28 18:34:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/511783003/20001
6 years, 3 months ago (2014-08-28 18:35:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 18:42:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 683a37692bc67ef1144922b73a1e871e7e1e842e

Powered by Google App Engine
This is Rietveld 408576698