Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 511703002: Roll BoringSSL. (Closed)

Created:
6 years, 3 months ago by agl
Modified:
6 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll BoringSSL. Brings in the following commits: 1f3591d Export CBS_asn1_ber_to_der. 25c93ff Fix BN_sub documentation. 854dd65 Refactor server-side CertificateVerify handling. 5b8f104 Revise hash management for reading the Finished message. 880b14e Compute the Channel ID hash after ssl_get_message. 590cbe9 Introduce a hash_message parameter to ssl_get_message. 912806b Fix build (broken by MD4_CTX redefine). bbac844 Add missing <errno.h> include. 3cb50e0 Move a variable declaration to function start. 98ad22e Fix "integer constant is too large for 'long' type" errors. 58f9095 Remove hack in parsing PKCS#12. 0eb1aae Readd EC_GROUP_get_curve_GFp. 539112f Readd EVP_CIPHER_CTX_set_key_length. c9eb7ea Readd MD4. 8da9906 Rename some message functions for consistency. e58c4f5 Add a test to ensure False Start occurs. ef86550 Remove logic for non-signing client certificates. a08e49d Add basic TLS Channel ID tests. 4e99c52 Fix FalseStart-SessionTicketsDisabled tests. 2561dc3 Introduce a mechanism for base64 options. d698f32 Introduce EVP_DecodeBase64. 3a66e28 Update ssl3_get_channel_id for the simpler ECDSA_do_verify. d30a990 Implement TLS Channel ID in runner.go f9b96fa Fix flipped DTLS checks. 2a0c496 Fix duplicate test name. 8e16b6e Add PKCS#12 parser. 9c01e00 Rework support for ASN.1 BER. cc8fcf4 Add 40-bit RC2 support. 9169c96 Implement client side of TLS signed certificate stamps extension. c44d2f4 Convert all zero-argument functions to '(void)' BUG=none Committed: https://crrev.com/1867be14e3beac7a778a1c1084fe167597e43ac3 Cr-Commit-Position: refs/heads/master@{#292240}

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : Export CBS_asn1_ber_to_der #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
agl
agl@chromium.org changed reviewers: + davidben@chromium.org
6 years, 3 months ago (2014-08-27 00:10:03 UTC) #1
agl
6 years, 3 months ago (2014-08-27 00:10:03 UTC) #2
davidben
lgtm
6 years, 3 months ago (2014-08-27 00:29:36 UTC) #3
agl
The CQ bit was checked by agl@chromium.org
6 years, 3 months ago (2014-08-27 17:41:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/511703002/20001
6 years, 3 months ago (2014-08-27 17:42:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 18:56:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 19:01:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/10270)
6 years, 3 months ago (2014-08-27 19:01:34 UTC) #8
agl
The CQ bit was checked by agl@chromium.org
6 years, 3 months ago (2014-08-27 20:10:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/511703002/40001
6 years, 3 months ago (2014-08-27 20:10:27 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 21:26:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 66e0155af737042c680f8c0d991981d8bcfac55a
6 years, 3 months ago (2014-08-27 22:07:02 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:38 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1867be14e3beac7a778a1c1084fe167597e43ac3
Cr-Commit-Position: refs/heads/master@{#292240}

Powered by Google App Engine
This is Rietveld 408576698