Add a flag to let render process wait for java debugger

Add a flag to let render process wait for java debugger

A switch RENDERER_WAIT_FOR_JAVA_DEBUGGER is newly added to block
ChildProcessMain thread of ChildProcessService until a Java debugger is
attached.

BUG=378975
Committed: https://crrev.com/d7929e7eb431ae8c94e99d958b480934022f7a23
Cr-Commit-Position: refs/heads/master@{#292733}

[Jaekyun Seok (inactive), 2014-08-27 03:00:39]

jaekyun@chromium.org changed reviewers:
+ feng@chromium.org

[Jaekyun Seok (inactive), 2014-08-27 03:00:39]

Please review this patch.

[Feng Qian, 2014-08-27 17:45:29]

Jaekyun, thanks for the patch!

Please see my inlined comments.

https://codereview.chromium.org/511683003/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/BaseSwitches.java (right):

https://codereview.chromium.org/511683003/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/BaseSwitches.java:17: public static
final String WAIT_RENDERER_FOR_JAVA_DEBUGGER =
"wait-renderer-for-java-debugger";
renderer-wait-for-java-debugger sounds better.

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
(right):

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java:159:
Log.e(TAG, "Waiting for Java debugger to connect...");
Please remove both Log.e before committing.

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:365:
new ArrayList<String>(Arrays.asList(commandLine));
We should put render command line options in one place:

https://cs.corp.google.com/#clankium/src/content/browser/renderer_host/render...

[Jaekyun Seok (inactive), 2014-08-28 00:09:49]

PTAL

https://codereview.chromium.org/511683003/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/BaseSwitches.java (right):

https://codereview.chromium.org/511683003/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/BaseSwitches.java:17: public static
final String WAIT_RENDERER_FOR_JAVA_DEBUGGER =
"wait-renderer-for-java-debugger";
On 2014/08/27 17:45:29, Feng Qian wrote:
> renderer-wait-for-java-debugger sounds better.

Done.

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
(right):

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java:159:
Log.e(TAG, "Waiting for Java debugger to connect...");
On 2014/08/27 17:45:29, Feng Qian wrote:
> Please remove both Log.e before committing.

Done.

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/511683003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:365:
new ArrayList<String>(Arrays.asList(commandLine));
On 2014/08/27 17:45:29, Feng Qian wrote:
> We should put render command line options in one place:
> 
>
https://cs.corp.google.com/#clankium/src/content/browser/renderer_host/render...

Done.

[Jaekyun Seok (inactive), 2014-08-28 00:17:45]

jaekyun@chromium.org changed reviewers:
+ ccameron@chromium.org, yfriedman@chromium.org

[Jaekyun Seok (inactive), 2014-08-28 00:25:32]

jaekyun@chromium.org changed reviewers:
+ creis@chromium.org

[Jaekyun Seok (inactive), 2014-08-28 00:25:32]

creis@chromium.org: Please review changes in

[Charlie Reis, 2014-08-28 16:38:37]

I'm not a good reviewer for
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java,
so please have someone else approve that.

The rest of content/ LGTM with a few nits.

https://codereview.chromium.org/511683003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/511683003/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_process_host_impl.cc:1248:
switches::kRendererWainForJavaDebugger,
Wain -> Wait

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:896: // Block ChildProcessMain thread
of render process service until a Java debugger
render process service -> the renderer's ChildProcessService

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
content/public/common/content_switches.h:260: CONTENT_EXPORT extern const char
kRendererWainForJavaDebugger[];
Wain -> Wait

[ccameron, 2014-08-28 17:22:19]

OWNER lgtm for RHWVImpl (w existing comments).

[Jaekyun Seok (inactive), 2014-08-28 23:41:16]

PTAL.

https://codereview.chromium.org/511683003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/511683003/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_process_host_impl.cc:1248:
switches::kRendererWainForJavaDebugger,
On 2014/08/28 16:38:37, Charlie Reis wrote:
> Wain -> Wait

Done.

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:896: // Block ChildProcessMain thread
of render process service until a Java debugger
On 2014/08/28 16:38:37, Charlie Reis wrote:
> render process service -> the renderer's ChildProcessService

Done.

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/511683003/diff/40001/content/public/common/co...
content/public/common/content_switches.h:260: CONTENT_EXPORT extern const char
kRendererWainForJavaDebugger[];
On 2014/08/28 16:38:37, Charlie Reis wrote:
> Wain -> Wait

Done.

[Jaekyun Seok (inactive), 2014-08-29 01:09:41]

Feng, could you please review changes on android java files?

[Feng Qian, 2014-08-29 16:01:05]

lgtm

[Charlie Reis, 2014-08-29 16:48:55]

content/ still LGTM

[Jaekyun Seok (inactive), 2014-08-29 20:58:45]

jaekyun@chromium.org changed reviewers:
+ nyquist@chromium.org

[Jaekyun Seok (inactive), 2014-08-29 20:58:46]

Tommy, could you please review changes on BaseSwitches.java?

[nyquist, 2014-08-29 21:00:59]

base/android lgtm

[Jaekyun Seok (inactive), 2014-08-29 21:08:26]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2014-08-30 00:28:27]

Committed patchset #4 (id:60001) as 7b1434f2c54d21e5f1b387c90e8af36fd70ecde6

[commit-bot: I haz the power, 2014-09-10 03:12:20]

Patchset 4 (id:??) landed as
https://crrev.com/d7929e7eb431ae8c94e99d958b480934022f7a23
Cr-Commit-Position: refs/heads/master@{#292733}