tools/perf/record_android_profile.py - Issue 511653002: Add profiling_controller that manages profilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/record_android_profile.py

Issue 511653002: Add profiling_controller that manages profilers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/record_android_profile.py

diff --git a/tools/perf/record_android_profile.py b/tools/perf/record_android_profile.py

index 8c8c5ab2c6be65f83a5801bfe7e736c3b1c9f24a..6e8ab8130c7b91af2c37fb22d61fedccbe0bcbae 100755

--- a/tools/perf/record_android_profile.py

+++ b/tools/perf/record_android_profile.py

@@ -20,14 +20,15 @@ def _RunPrebuilt(options):

output_file = os.path.join(tempfile.mkdtemp(), options.profiler)

raw_input('Press enter to start profiling...')

print '>> Starting profiler', options.profiler

- browser.StartProfiling(options.profiler, output_file)

+ browser.platform.profiling_controller.Start(

+ options.profiler, output_file)

print 'Press enter or CTRL+C to stop'

try:

raw_input()

except KeyboardInterrupt:

pass

finally:

- browser.StopProfiling()

+ browser.platform.profiling_controller.Stop()

print '<< Stopped profiler ', options.profiler

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »