tools/telemetry/telemetry/page/page_runner.py - Issue 511653002: Add profiling_controller that manages profilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 511653002: Add profiling_controller that manages profilers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/profilers_controller/profiling_controller Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 479dd5f6718a1b9eda4cf3aa9e1652987dbaf8e2..8b9c1d1c70ca18cad3f8986cfc92a0e619160371 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -135,11 +135,12 @@ class _RunState(object):

finder_options.pageset_repeat != 1)

if is_repeating:

output_file = util.GetSequentialFileName(output_file)

- self.browser.StartProfiling(finder_options.profiler, output_file)

+ self.browser.platform.profiling_controller.StartProfiling(

+ finder_options.profiler, output_file)

def StopProfiling(self):

if self.browser:

- self.browser.StopProfiling()

+ self.browser.platform.profiling_controller.StopProfiling()

class PageState(object):