Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/rappor/rappor_service_unittest.cc

Issue 511623002: Add a mechanism for collecting Rappor samples on a daily interval. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/rappor_service.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/rappor_service_unittest.cc
diff --git a/components/rappor/rappor_service_unittest.cc b/components/rappor/rappor_service_unittest.cc
index a91db8c03221d9f44194ade2fd50cc0a8421d4da..4430ee3eb9827ed160d02b6c0147efb40fb2d325 100644
--- a/components/rappor/rappor_service_unittest.cc
+++ b/components/rappor/rappor_service_unittest.cc
@@ -4,23 +4,44 @@
#include "components/rappor/rappor_service.h"
+#include "base/base64.h"
+#include "base/prefs/testing_pref_service.h"
#include "components/rappor/byte_vector_utils.h"
#include "components/rappor/proto/rappor_metric.pb.h"
#include "components/rappor/rappor_parameters.h"
+#include "components/rappor/rappor_pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace rappor {
class TestRapporService : public RapporService {
public:
+ TestRapporService() : RapporService(&prefs_) {
+ RegisterPrefs(prefs_.registry());
+ prefs_.SetInteger(prefs::kRapporCohortSeed, 0);
+ std::string secret = HmacByteVectorGenerator::GenerateEntropyInput();
+ std::string secret_base64;
+ base::Base64Encode(secret, &secret_base64);
+ prefs_.SetString(prefs::kRapporSecret, secret_base64);
+ LoadCohort();
+ LoadSecret();
+ }
+
void GetReports(RapporReports* reports) {
ExportMetrics(reports);
}
+
void TestRecordSample(const std::string& metric_name,
const RapporParameters& parameters,
const std::string& sample) {
RecordSampleInternal(metric_name, parameters, sample);
}
+
+ protected:
+ TestingPrefServiceSimple prefs_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TestRapporService);
};
TEST(RapporServiceTest, RecordAndExportMetrics) {
@@ -34,9 +55,6 @@ TEST(RapporServiceTest, RecordAndExportMetrics) {
PROBABILITY_50 /* Zero coin probability */};
TestRapporService rappor_service;
- rappor_service.SetCohortForTesting(0);
- rappor_service.SetSecretForTesting(
- HmacByteVectorGenerator::GenerateEntropyInput());
rappor_service.TestRecordSample("MyMetric", kTestRapporParameters, "foo");
rappor_service.TestRecordSample("MyMetric", kTestRapporParameters, "bar");
« no previous file with comments | « components/rappor/rappor_service.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698