Issue 511603002: Prevent CopyOutputRequest from crashing when using surfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511603002: Prevent CopyOutputRequest from crashing when using surfaces. (Closed)

Created:
6 years, 3 months ago by jbauman

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Prevent CopyOutputRequest from crashing when using surfaces. It was hitting a DCHECK when attempting to copy the CopyOutputRequest whenever navigating between pages. BUG= Committed: https://crrev.com/5d0211f25cf223656a4eb231eea222fe0fb27bf0 Cr-Commit-Position: refs/heads/master@{#292037}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	content/browser/compositor/delegated_frame_host.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jbauman

jbauman@chromium.org changed reviewers: + jamesr@chromium.org

6 years, 3 months ago (2014-08-26 21:49:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/511603002/1

6 years, 3 months ago (2014-08-26 21:53:57 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as fb89fd6f1cc2c30d411e6f02e741d737df03f800

6 years, 3 months ago (2014-08-26 23:51:41 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:47:33 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5d0211f25cf223656a4eb231eea222fe0fb27bf0
Cr-Commit-Position: refs/heads/master@{#292037}

Expand Messages | Collapse Messages