Issue 511583002: Update mojo's WebMimeRegistry for supportsImagePrefixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511583002: Update mojo's WebMimeRegistry for supportsImagePrefixed (Closed)

Created:
6 years, 3 months ago by jamesr

Modified:
6 years, 3 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Committed: https://crrev.com/22317f423d71cce75c689fcd184e58d4169188d5 Cr-Commit-Position: refs/heads/master@{#291981}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	mojo/services/html_viewer/webmimeregistry_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	mojo/services/html_viewer/webmimeregistry_impl.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM Why was this method made pure virtual upstream? Ordinarily, blink API methods that need ...

6 years, 3 months ago (2014-08-26 21:03:38 UTC) #2

jamesr

WebMimeRegistry is all pure virtual. I approved this addition since it was consistent, not sure ...

6 years, 3 months ago (2014-08-26 21:04:43 UTC) #3

jamesr

Committed patchset #1 to pending queue manually as 8386dd7 (presubmit successful).

6 years, 3 months ago (2014-08-26 21:09:24 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:45:36 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22317f423d71cce75c689fcd184e58d4169188d5
Cr-Commit-Position: refs/heads/master@{#291981}

Expand Messages | Collapse Messages