Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 511543005: Revert of mojo: generate Proxies and Stubs for java bindings. (Closed)

Created:
6 years, 3 months ago by Thiemo Nagel
Modified:
6 years, 3 months ago
Reviewers:
rmcilroy, qsr, ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: generate Proxies and Stubs for java bindings. (patchset #16 of https://codereview.chromium.org/411913002/) Reason for revert: Fails license check on android bot: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64641 Original issue's description: > mojo: generate Proxies and Stubs for java bindings. > > This CL allows to generate Stub and Proxy of mojo service in java. This > allows to call interfaces method through message pipes. > > Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57 TBR=ppi@chromium.org,rmcilroy@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8b9e346baf858fd2c4aca745c188e633185c0b99 Cr-Commit-Position: refs/heads/master@{#292137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1251 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTestUtils.java View 2 chunks +3 lines, -12 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java View 4 chunks +5 lines, -6 lines 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java View 1 chunk +0 lines, -335 lines 0 comments Download
M mojo/public/java/BUILD.gn View 1 chunk +17 lines, -19 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java View 2 chunks +1 line, -8 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 7 chunks +22 lines, -72 lines 0 comments Download
D mojo/public/java/bindings/src/org/chromium/mojo/bindings/DelegatingConnectionErrorHandler.java View 1 chunk +0 lines, -49 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 5 chunks +16 lines, -36 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/HandleOwner.java View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 1 chunk +1 line, -240 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java View 1 chunk +4 lines, -39 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java View 2 chunks +2 lines, -84 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageHeader.java View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageReceiver.java View 1 chunk +1 line, -9 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Router.java View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/RouterImpl.java View 2 chunks +0 lines, -14 lines 0 comments Download
D mojo/public/java/bindings/src/org/chromium/mojo/bindings/SideEffectFreeCloseable.java View 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 5 chunks +7 lines, -233 lines 0 comments Download
D mojo/public/tools/bindings/generators/java_templates/interface_internal.java.tmpl View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 8 chunks +18 lines, -55 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Thiemo Nagel
Created Revert of mojo: generate Proxies and Stubs for java bindings.
6 years, 3 months ago (2014-08-27 12:35:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/511543005/1
6 years, 3 months ago (2014-08-27 12:35:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 7435ee4c6016695390b3e7baf4918ef62b60b592
6 years, 3 months ago (2014-08-27 12:36:12 UTC) #3
qsr
LGTM
6 years, 3 months ago (2014-08-27 13:02:58 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:12 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b9e346baf858fd2c4aca745c188e633185c0b99
Cr-Commit-Position: refs/heads/master@{#292137}

Powered by Google App Engine
This is Rietveld 408576698