chrome/test/remoting/remote_desktop_browsertest.cc - Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/remoting/remote_desktop_browsertest.cc

Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move download out Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy.cc ('k') | chrome/utility/local_discovery/service_discovery_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/remoting/remote_desktop_browsertest.cc

diff --git a/chrome/test/remoting/remote_desktop_browsertest.cc b/chrome/test/remoting/remote_desktop_browsertest.cc

index 18b9f85c26ac9ce929072cc14876d5f2afefb9d5..7966b5c183ab9d0e037fd1324fde844d4fd45e48 100644

--- a/chrome/test/remoting/remote_desktop_browsertest.cc

+++ b/chrome/test/remoting/remote_desktop_browsertest.cc

@@ -152,7 +152,7 @@ void RemoteDesktopBrowserTest::VerifyChromotingLoaded(bool expected) {

if (installed) {

if (extension_)

- EXPECT_EQ(extension, extension_);

+ EXPECT_EQ(extension.get(), extension_);

else

extension_ = extension.get();