chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc - Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move download out Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/search/hotword_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

index 951144a1e27e00df97a2449afb797f07d03b7d8c..41f76c06a300f2d288f2f3ed5717127271f25aac 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

@@ -842,7 +842,7 @@ void IncidentReportingService::UploadIfCollectionComplete() {

scoped_ptr<UploadContext> context(new UploadContext(report.Pass()));

context->profiles_to_state.swap(profiles_to_state);

- if (!database_manager_) {

+ if (!database_manager_.get()) {

// No database manager during testing. Take ownership of the context and

// continue processing.

UploadContext* temp_context = context.get();