chrome/browser/profile_resetter/profile_resetter_unittest.cc - Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profile_resetter/profile_resetter_unittest.cc

Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move download out Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_policy_signin_service_base.h ('k') | chrome/browser/profile_resetter/resettable_settings_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profile_resetter/profile_resetter_unittest.cc

diff --git a/chrome/browser/profile_resetter/profile_resetter_unittest.cc b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

index c8e31dc28d313a02a4267590a8859bba53ea40b1..cbaf2323673bbf45155aa662f0ebc5dd719e30a6 100644

--- a/chrome/browser/profile_resetter/profile_resetter_unittest.cc

+++ b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

@@ -864,7 +864,7 @@ TEST_F(ProfileResetterTest, CheckSnapshots) {

Manifest::INVALID_LOCATION,

extensions::Manifest::TYPE_EXTENSION,

false);

- ASSERT_TRUE(ext);

+ ASSERT_TRUE(ext.get());

service_->AddExtension(ext.get());

std::string master_prefs(kDistributionConfig);

@@ -953,7 +953,7 @@ TEST_F(ProfileResetterTest, FeedbackSerializationTest) {

Manifest::INVALID_LOCATION,

extensions::Manifest::TYPE_EXTENSION,

false);

- ASSERT_TRUE(ext);

+ ASSERT_TRUE(ext.get());

service_->AddExtension(ext.get());

ShortcutHandler shortcut;

@@ -1032,7 +1032,7 @@ TEST_F(ProfileResetterTest, GetReadableFeedback) {

Manifest::INVALID_LOCATION,

extensions::Manifest::TYPE_EXTENSION,

false);

- ASSERT_TRUE(ext);

+ ASSERT_TRUE(ext.get());

service_->AddExtension(ext.get());

PrefService* prefs = profile()->GetPrefs();