Made ChromeSyncShellTest.apk run on the fyi-tests bot.

Made ChromeSyncShellTest.apk run on the fyi-tests bot.

BUG=406538
Committed: https://crrev.com/0178d4831bd36b5fb9ff477f03dc43b11626a6dc
Cr-Commit-Position: refs/heads/master@{#292238}

[mikecase (-- gone --), 2014-08-26 17:44:22]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2014-08-26 17:44:22]

In this change, I wasn't really sure if I should use
'chrome:chrome/test/data/android/device_files' for the test_data field for the
new chrome shell sync tests. It appears to just effect the logo or some icons?

[mikecase (-- gone --), 2014-08-26 17:45:52]

On 2014/08/26 17:44:22, mikecase wrote:
> In this change, I wasn't really sure if I should use
> 'chrome:chrome/test/data/android/device_files' for the test_data field for the
> new chrome shell sync tests. It appears to just effect the logo or some icons?

Also, Ill to submitting a recipe change to the upstream build repo. That change
will make the chrome shell sync tests run on a trybot and maybe one other bot.

[klundberg, 2014-08-26 17:48:58]

On 2014/08/26 17:45:52, mikecase wrote:
> On 2014/08/26 17:44:22, mikecase wrote:
> > In this change, I wasn't really sure if I should use
> > 'chrome:chrome/test/data/android/device_files' for the test_data field for
the
> > new chrome shell sync tests. It appears to just effect the logo or some
icons?
> 
> Also, Ill to submitting a recipe change to the upstream build repo. That
change
> will make the chrome shell sync tests run on a trybot and maybe one other bot.

Just please make sure that you add them to a FYI try bot until we know the
stability of the tests.

[jbudorick, 2014-08-26 17:59:53]

https://codereview.chromium.org/511453003/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/511453003/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:70: I('ChromeSyncShell',
Mentioned offline, but for the record: This will run ChromeSyncShellTests
wherever we run the other instrumentation tests on bots still running the
buildbot scripts. While this is what we eventually want to do, it isn't how we
want to start.

Add a separate test step command that just runs these sync tests and have the
fyi bots run that step.

[mikecase (-- gone --), 2014-08-27 18:18:50]

On 2014/08/26 17:59:53, jbudorick wrote:
>
https://codereview.chromium.org/511453003/diff/1/build/android/buildbot/bb_de...
> File build/android/buildbot/bb_device_steps.py (right):
> 
>
https://codereview.chromium.org/511453003/diff/1/build/android/buildbot/bb_de...
> build/android/buildbot/bb_device_steps.py:70: I('ChromeSyncShell',
> Mentioned offline, but for the record: This will run ChromeSyncShellTests
> wherever we run the other instrumentation tests on bots still running the
> buildbot scripts. While this is what we eventually want to do, it isn't how we
> want to start.
> 
> Add a separate test step command that just runs these sync tests and have the
> fyi bots run that step.

Made the changes we discussed. Please take a look when you have time.

[jbudorick, 2014-08-27 18:21:28]

jbudorick@chromium.org changed reviewers:
+ navabi@chromium.org

[jbudorick, 2014-08-27 18:21:28]

+navabi since it's in the buildbot scripts, but this is ok with me.

[klundberg, 2014-08-27 18:33:34]

klundberg@chromium.org changed reviewers:
+ klundberg@chromium.org

[klundberg, 2014-08-27 18:33:34]

This looks ok to me too but Armand knows best:-)

[navabi1, 2014-08-27 18:48:05]

lgtm with small nit: Please update the description to include what bots this
will run on. Currently it just says "some of the bots"

[mikecase (-- gone --), 2014-08-27 20:53:00]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:55:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mikecase@chromium.org/511453003/20001

[commit-bot: I haz the power, 2014-08-27 21:58:39]

Committed patchset #2 (id:20001) as f1d2c1d1bc3a96f82a97f57bfdbf3fc063393fa4

[commit-bot: I haz the power, 2014-09-10 02:54:35]

Patchset 2 (id:??) landed as
https://crrev.com/0178d4831bd36b5fb9ff477f03dc43b11626a6dc
Cr-Commit-Position: refs/heads/master@{#292238}