Mojo javascript encoder: Empty string encoded as NULL.

Mojo javascript encoder: Empty string encoded as NULL.

Instead, encode null as NULL (and not just any falsy value) via
a == comparison with null (and use ==, not === to treat undefined
the same way as null).

BUG=407258
Committed: https://crrev.com/c1a2be03ea10bf2416b614779909ea0d20bb683c
Cr-Commit-Position: refs/heads/master@{#292221}

[Tom Sepez, 2014-08-26 16:54:41]

tsepez@chromium.org changed reviewers:
+ yzshen@chromium.org

[Tom Sepez, 2014-08-26 16:54:41]

Yuzhu, please review. Thanks.

[yzshen1, 2014-08-26 17:30:19]

LGTM, thanks!

Does it make sense to also add your comment to the code:

"""encode null as NULL (and not just any falsy value) via
a == comparison with null (and use ==, not === to treat undefined the same way
as null)."""

[Tom Sepez, 2014-08-26 18:31:06]

Does it make sense to also add your comment to the code:
> 
> """encode null as NULL (and not just any falsy value) via
> a == comparison with null (and use ==, not === to treat undefined the same way
> as null)."""
Added similar comment.

[yzshen1, 2014-08-26 19:03:52]

On 2014/08/26 18:31:06, Tom Sepez wrote:
> Does it make sense to also add your comment to the code:
> > 
> > """encode null as NULL (and not just any falsy value) via
> > a == comparison with null (and use ==, not === to treat undefined the same
way
> > as null)."""
> Added similar comment.

Still LGTM

Thanks!

[Tom Sepez, 2014-08-27 17:27:25]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-08-27 17:27:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tsepez@chromium.org/511443002/20001

[commit-bot: I haz the power, 2014-08-27 19:38:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-27 20:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:39:01]

Failed to commit the patch.

[Tom Sepez, 2014-08-27 21:10:16]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-08-27 21:11:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tsepez@chromium.org/511443002/20001

[commit-bot: I haz the power, 2014-08-27 21:12:43]

Committed patchset #2 (id:20001) as e602b151b4760b70d65563c8fad0a621124ad99c

[commit-bot: I haz the power, 2014-09-10 02:53:58]

Patchset 2 (id:??) landed as
https://crrev.com/c1a2be03ea10bf2416b614779909ea0d20bb683c
Cr-Commit-Position: refs/heads/master@{#292221}