chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 511393003: No longer register app window placement preference keys on the fly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 511393003: No longer register app window placement preference keys on the fly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move to own file and start unit tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index 234af6bd046ef7bb0558444cb50a30726484b95c..c6f27530d425b6b5b397389f5eb489f7e69df7ec 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -119,10 +119,11 @@ const CGFloat kLocBarBottomInset = 1;

gfx::Rect workArea(NSRectToCGRect([windowScreen visibleFrame]));

workArea.set_y(monitorFrame.size.height - workArea.y() - workArea.height());

- DictionaryPrefUpdate update(

- prefs,

- chrome::GetWindowPlacementKey(browser_.get()).c_str());

- base::DictionaryValue* windowPreferences = update.Get();

+ scoped_ptr<DictionaryPrefUpdate> update =

+ chrome::GetWindowPlacementDictionaryReadWrite(

+ chrome::GetWindowName(browser_.get()),

+ browser_->profile()->GetPrefs());

+ base::DictionaryValue* windowPreferences = update->Get();

windowPreferences->SetInteger("left", bounds.x());

windowPreferences->SetInteger("top", bounds.y());

windowPreferences->SetInteger("right", bounds.right());