chrome/browser/ui/window_sizer/window_sizer.cc - Issue 511393003: No longer register app window placement preference keys on the fly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/window_sizer/window_sizer.cc

Issue 511393003: No longer register app window placement preference keys on the fly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/window_sizer/window_sizer.cc

diff --git a/chrome/browser/ui/window_sizer/window_sizer.cc b/chrome/browser/ui/window_sizer/window_sizer.cc

index 34b342b05985c9642d5765b902271582633b2974..1d61e1db9bfd879f66ebc261fb3cd21b10ad3cd9 100644

--- a/chrome/browser/ui/window_sizer/window_sizer.cc

+++ b/chrome/browser/ui/window_sizer/window_sizer.cc

@@ -51,9 +51,8 @@ class DefaultStateProvider : public WindowSizer::StateProvider {

if (!browser_ || !browser_->profile()->GetPrefs())

return false;

- std::string window_name(chrome::GetWindowPlacementKey(browser_));

const base::DictionaryValue* wp_pref =

- browser_->profile()->GetPrefs()->GetDictionary(window_name.c_str());

+ chrome::GetWindowPlacementDictionaryReadOnly(browser_);

int top = 0, left = 0, bottom = 0, right = 0;

bool maximized = false;

bool has_prefs = wp_pref &&