Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 511393003: No longer register app window placement preference keys on the fly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make member variables local Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 8 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
9 #include "chrome/browser/devtools/devtools_toggle_action.h" 9 #include "chrome/browser/devtools/devtools_toggle_action.h"
10 #include "chrome/browser/devtools/devtools_ui_bindings.h" 10 #include "chrome/browser/devtools/devtools_ui_bindings.h"
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 const std::string& settings); 219 const std::string& settings);
220 static DevToolsWindow* FindDevToolsWindow(content::DevToolsAgentHost*); 220 static DevToolsWindow* FindDevToolsWindow(content::DevToolsAgentHost*);
221 static DevToolsWindow* AsDevToolsWindow(content::WebContents*); 221 static DevToolsWindow* AsDevToolsWindow(content::WebContents*);
222 static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile); 222 static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile);
223 static DevToolsWindow* ToggleDevToolsWindow( 223 static DevToolsWindow* ToggleDevToolsWindow(
224 content::WebContents* web_contents, 224 content::WebContents* web_contents,
225 bool force_open, 225 bool force_open,
226 const DevToolsToggleAction& action, 226 const DevToolsToggleAction& action,
227 const std::string& settings); 227 const std::string& settings);
228 228
229 static std::string GetDevToolsWindowPlacementPrefKey();
230
231 // content::WebContentsDelegate: 229 // content::WebContentsDelegate:
232 virtual content::WebContents* OpenURLFromTab( 230 virtual content::WebContents* OpenURLFromTab(
233 content::WebContents* source, 231 content::WebContents* source,
234 const content::OpenURLParams& params) OVERRIDE; 232 const content::OpenURLParams& params) OVERRIDE;
235 virtual void ActivateContents(content::WebContents* contents) OVERRIDE; 233 virtual void ActivateContents(content::WebContents* contents) OVERRIDE;
236 virtual void AddNewContents(content::WebContents* source, 234 virtual void AddNewContents(content::WebContents* source,
237 content::WebContents* new_contents, 235 content::WebContents* new_contents,
238 WindowOpenDisposition disposition, 236 WindowOpenDisposition disposition,
239 const gfx::Rect& initial_pos, 237 const gfx::Rect& initial_pos,
240 bool user_gesture, 238 bool user_gesture,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 base::Closure close_callback_; 311 base::Closure close_callback_;
314 312
315 base::TimeTicks inspect_element_start_time_; 313 base::TimeTicks inspect_element_start_time_;
316 scoped_ptr<DevToolsEventForwarder> event_forwarder_; 314 scoped_ptr<DevToolsEventForwarder> event_forwarder_;
317 315
318 friend class DevToolsEventForwarder; 316 friend class DevToolsEventForwarder;
319 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 317 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
320 }; 318 };
321 319
322 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 320 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698