media: Remove FilterCollection.

media: Remove FilterCollection.

Now we pass Demuxer and Renderer directly into Pipeline, and create TextRenderer
directly in Pipeline. As a result, we don't need FilterCollection anymore.

BUG=408602
TEST=All existing tests pass.

Committed: https://crrev.com/5980590f8c9a20b07192d9f36d33053b1b3ff8c8
Cr-Commit-Position: refs/heads/master@{#292542}

[xhwang, 2014-08-28 18:38:00]

xhwang@chromium.org changed reviewers:
+ scherkus@chromium.org

[xhwang, 2014-08-28 18:38:00]

PTAL

[scherkus (not reviewing), 2014-08-28 18:48:22]

nice cleanup!

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.cc
File media/base/pipeline.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.cc#n...
media/base/pipeline.cc:343: // Report meta data the first time we enter the
playing state.
nit: metadata

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.h
File media/base/pipeline.h (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.h#ne...
media/base/pipeline.h:277: void ReportMetaData();
nit: Metadata

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
File media/base/pipeline_unittest.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
media/base/pipeline_unittest.cc:132: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
IIRC this executes once per test

typically we've put flag-setting code where it executes once inside of
run_all_unittests.cc

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
media/filters/pipeline_integration_test.cc:557: base::Unretained(this)));
indent looks wrong

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
media/filters/pipeline_integration_test.cc:587: base::Unretained(this)));
indent looks wrong

[xhwang, 2014-08-28 19:51:51]

comments addressed

[xhwang, 2014-08-28 19:52:05]

PTAL again

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.cc
File media/base/pipeline.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.cc#n...
media/base/pipeline.cc:343: // Report meta data the first time we enter the
playing state.
On 2014/08/28 18:48:22, scherkus wrote:
> nit: metadata

Done.

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.h
File media/base/pipeline.h (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline.h#ne...
media/base/pipeline.h:277: void ReportMetaData();
On 2014/08/28 18:48:22, scherkus wrote:
> nit: Metadata

Done.

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
File media/base/pipeline_unittest.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
media/base/pipeline_unittest.cc:132: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
On 2014/08/28 18:48:22, scherkus wrote:
> IIRC this executes once per test
> 
> typically we've put flag-setting code where it executes once inside of
> run_all_unittests.cc

Done.

But I actually searched run_all_unittests.cc and didn't see any example...

https://code.google.com/p/chromium/codesearch#search/&q=run_all_unittests.cc%...

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
media/filters/pipeline_integration_test.cc:557: base::Unretained(this)));
On 2014/08/28 18:48:22, scherkus wrote:
> indent looks wrong

Done.

https://codereview.chromium.org/511323003/diff/20001/media/filters/pipeline_i...
media/filters/pipeline_integration_test.cc:587: base::Unretained(this)));
On 2014/08/28 18:48:22, scherkus wrote:
> indent looks wrong

Done.

[scherkus (not reviewing), 2014-08-28 19:57:18]

lgtm

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
File media/base/pipeline_unittest.cc (right):

https://codereview.chromium.org/511323003/diff/20001/media/base/pipeline_unit...
media/base/pipeline_unittest.cc:132: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
On 2014/08/28 19:52:05, xhwang wrote:
> On 2014/08/28 18:48:22, scherkus wrote:
> > IIRC this executes once per test
> > 
> > typically we've put flag-setting code where it executes once inside of
> > run_all_unittests.cc
> 
> Done.
> 
> But I actually searched run_all_unittests.cc and didn't see any example...
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=run_all_unittests.cc%...

That's because we've launched features / enabled them by default :)

e.g.,
https://chromium.googlesource.com/chromium/src/+/2c4564e640136bb021e246efc94a...

[xhwang, 2014-08-28 20:24:05]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2014-08-28 20:24:05]

jam@: Could you please OWNERS review changes in content/ (except for
content/renderer/media/)? It's mostly about moving a command line switch from
content/ to media/, which should be pretty easy to review. Thanks!

[jam, 2014-08-28 23:42:22]

lgtm

[xhwang, 2014-08-29 00:15:08]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-08-29 00:16:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/511323003/100001

[commit-bot: I haz the power, 2014-08-29 01:44:22]

Committed patchset #6 (id:100001) as 3edd5c5a6141d88eefd495cea107a4d15f237582

[commit-bot: I haz the power, 2014-09-10 03:05:04]

Patchset 6 (id:??) landed as
https://crrev.com/5980590f8c9a20b07192d9f36d33053b1b3ff8c8
Cr-Commit-Position: refs/heads/master@{#292542}