Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 511313002: Manual fixups in remoting/ for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups in remoting/ for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/04e05b5d2a783d3e9a260db685b51e39a51039f2 Cr-Commit-Position: refs/heads/master@{#292467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M remoting/client/client_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/client/client_context.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + wez@chromium.org
6 years, 3 months ago (2014-08-28 17:32:23 UTC) #1
dcheng
Simple fixup--since the constructor immediately saves the raw pointer into a scoped_refptr, and callers are ...
6 years, 3 months ago (2014-08-28 17:32:23 UTC) #2
Wez
LGTM - thanks Daniel!
6 years, 3 months ago (2014-08-28 20:01:09 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 20:16:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/511313002/1
6 years, 3 months ago (2014-08-28 20:17:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a13035e9eff8122c44da1017e51e8d6784c2da7f
6 years, 3 months ago (2014-08-28 21:39:07 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04e05b5d2a783d3e9a260db685b51e39a51039f2
Cr-Commit-Position: refs/heads/master@{#292467}

Powered by Google App Engine
This is Rietveld 408576698