Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 511283005: Go away on odd push and already seen push stream ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add push stream handling to OnUnknownFrame Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session_unittest.cc
diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc
index ec4cb3c43c0f690c9246e7542a6284007c28249e..51aa70af2a72cabb58f5021f44d9a87ff25a6147 100644
--- a/net/spdy/spdy_session_unittest.cc
+++ b/net/spdy/spdy_session_unittest.cc
@@ -4975,9 +4975,12 @@ TEST_P(SpdySessionTest, RejectInvalidUnknownFrames) {
EXPECT_TRUE(session->OnUnknownFrame(3, 0));
// Client id exceeding watermark.
EXPECT_FALSE(session->OnUnknownFrame(9, 0));
- // Currently we do not keep track of server initiated (even) ids.
+
+ session->last_accepted_push_stream_id_ = 6;
+ // Low server (even) ids are fine.
EXPECT_TRUE(session->OnUnknownFrame(2, 0));
- EXPECT_TRUE(session->OnUnknownFrame(8, 0));
+ // Server id exceeding last accepted id.
+ EXPECT_FALSE(session->OnUnknownFrame(8, 0));
}
TEST(MapFramerErrorToProtocolError, MapsValues) {
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698