Go away on odd push and already seen push stream ids

Go away on odd push and already seen push stream ids

BUG=377538
R=jgraettinger@chromium.org

TEST=SpdyNetworkTransactionTest.GoAwayOnPushStreamIdLesserOrEqualThanLastAccepted
     SpdyNetworkTransactionTest.GoAwayOnOddPushStreamId

Committed: https://crrev.com/212a1299355dc97c4e45b6997b4901a1cd10f286
Cr-Commit-Position: refs/heads/master@{#293002}

[baranovich, 2014-09-02 13:05:22]

This CL implements going away on odd push stream ids and if new push stream id
is lesser or equal to the last seen push stream id. Not sure if we should
implement going away on push stream id exhaustion.

[Johnny, 2014-09-02 18:34:20]

lgtm, thanks for doing this!

> Not sure if we should implement going away on push stream id exhaustion.

I think it's best to leave that up to the origin.

https://codereview.chromium.org/511283005/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/511283005/diff/1/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:2364: // TODO(bnc):  Track highest id for server
initiated streams.
Optional bonus points: This TODO can be fixed now that
|last_accepted_push_stream_id_| exists.

Briefly, this method is used by SpdyFramer to sanity check the stream ID seen in
an extension frame with otherwise unknown semantics.

[baranovich, 2014-09-02 19:02:19]

Done, PTAL once more

https://codereview.chromium.org/511283005/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/511283005/diff/1/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:2364: // TODO(bnc):  Track highest id for server
initiated streams.
On 2014/09/02 18:34:20, Johnny wrote:
> Optional bonus points: This TODO can be fixed now that
> |last_accepted_push_stream_id_| exists.
> 
> Briefly, this method is used by SpdyFramer to sanity check the stream ID seen
in
> an extension frame with otherwise unknown semantics.

Done.

[Johnny, 2014-09-02 19:06:03]

PS2 lgtm

[baranovich, 2014-09-02 19:06:58]

The CQ bit was checked by baranovich@yandex-team.ru

[commit-bot: I haz the power, 2014-09-02 19:07:58]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/baranovich@yandex-team.ru/511283005/20001

[commit-bot: I haz the power, 2014-09-02 21:10:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-02 21:46:55]

Committed patchset #2 (id:20001) as 096f3c079853b2ac29dc4bf0081b0d7b941b7bea

[commit-bot: I haz the power, 2014-09-10 03:21:00]

Patchset 2 (id:??) landed as
https://crrev.com/212a1299355dc97c4e45b6997b4901a1cd10f286
Cr-Commit-Position: refs/heads/master@{#293002}