Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 511283003: Add support for Java nano protocol buffers for Android. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Colin Meek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for Java nano protocol buffers for Android. This CL adds a new dependency on the protocol buffer compiler from the android source tree, since this compiler supports generating Java files using the nano runtime. The initial version of this dependency is 2.2.0a, but checked out as what the Android 4.4.4 Release 2.0.1 tag points to. This CL adds a new protoc binary (for compiling protos) that supports this, and also adds a Java library with the runtime. To simplify use of this, it also updates build/protoc_java.gypi to support generating nano protos by specifying an optional proto_runtime argument. The argument defaults to 'lite' which does the same thing as before this change, and setting it to 'nano' generates the new style Java files. The plan is to quickly deprecate the 'lite' runtime for Java, since it is too big and uses too many methods. BUG=377891 Committed: https://crrev.com/a076bf3d5a204c2e2db473a687b34c17830866bc Cr-Commit-Position: refs/heads/master@{#292965}

Patch Set 1 #

Patch Set 2 : Add OWNERS #

Patch Set 3 : Fix newline issue after style fix #

Total comments: 2

Patch Set 4 : addressed comments from darin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -17 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M build/protoc_java.gypi View 3 chunks +25 lines, -5 lines 0 comments Download
M build/protoc_java.py View 1 2 3 chunks +23 lines, -11 lines 0 comments Download
A + third_party/android_protobuf/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/android_protobuf/README.chromium View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/android_protobuf/android_protobuf.gyp View 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
nyquist
nyquist@chromium.org changed reviewers: + cjhopman@chromium.org
6 years, 3 months ago (2014-08-28 17:18:37 UTC) #1
nyquist
cjhopman: PTAL
6 years, 3 months ago (2014-08-28 17:18:37 UTC) #2
cjhopman
lgtm
6 years, 3 months ago (2014-08-29 18:07:55 UTC) #3
nyquist
darin: Please review changes in //third_party/
6 years, 3 months ago (2014-08-29 20:52:38 UTC) #5
darin (slow to review)
LGTM https://codereview.chromium.org/511283003/diff/40001/third_party/android_protobuf/README.chromium File third_party/android_protobuf/README.chromium (right): https://codereview.chromium.org/511283003/diff/40001/third_party/android_protobuf/README.chromium#newcode19 third_party/android_protobuf/README.chromium:19: which generates Java-files which less methods than the ...
6 years, 3 months ago (2014-08-29 21:19:19 UTC) #6
nyquist
https://codereview.chromium.org/511283003/diff/40001/third_party/android_protobuf/README.chromium File third_party/android_protobuf/README.chromium (right): https://codereview.chromium.org/511283003/diff/40001/third_party/android_protobuf/README.chromium#newcode19 third_party/android_protobuf/README.chromium:19: which generates Java-files which less methods than the protobuf ...
6 years, 3 months ago (2014-08-29 21:27:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/511283003/60001
6 years, 3 months ago (2014-09-02 17:34:32 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as d8ae0a79834531e41912de44b9e212ffa7eb2785
6 years, 3 months ago (2014-09-02 18:41:27 UTC) #10
nyquist
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/534703004/ by nyquist@chromium.org. ...
6 years, 3 months ago (2014-09-02 22:15:22 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:38 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a076bf3d5a204c2e2db473a687b34c17830866bc
Cr-Commit-Position: refs/heads/master@{#292965}

Powered by Google App Engine
This is Rietveld 408576698