Issue 511263002: Don’t reset the page id when the browser takes the navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511263002: Don’t reset the page id when the browser takes the navigation. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)

Modified:
6 years, 3 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don’t reset the page id when the browser takes the navigation. When the browser takes the navigation, the current page doesn’t change, so it makes no sense to change the page id. This reverts a58db8b018960641d07dc72d9ff68b0f86f4b07b. BUG=407376 TEST=stuff is green Committed: https://crrev.com/46790669f8a2ecd7249ab92418260316b1c60dbf Cr-Commit-Position: refs/heads/master@{#292433}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

avi@chromium.org changed reviewers: + creis@chromium.org

6 years, 3 months ago (2014-08-28 15:43:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/511263002/1

6 years, 3 months ago (2014-08-28 17:49:49 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as b9e86f462f69e0e16bf184f63aa29a4a81c9cd4e

6 years, 3 months ago (2014-08-28 18:57:05 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:01:14 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/46790669f8a2ecd7249ab92418260316b1c60dbf
Cr-Commit-Position: refs/heads/master@{#292433}

Expand Messages | Collapse Messages