Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 511253005: Added irt extension support for supplying the nacl_irt_memory interface. (Closed)

Created:
6 years, 3 months ago by David Yen
Modified:
6 years, 3 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Added irt extension support for supplying the nacl_irt_memory interface. Memory calls such as mmap and munmap can now be supplied through the irt extension API to newlib. Unit tests have also been added to test if the supplied extension is being used properly. R=mcgrathr@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3918 TESTS = trybots, scons test "run_irt_ext_libc_test_irt" under newlib Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13682

Patch Set 1 #

Patch Set 2 : Forgot to add some files... #

Patch Set 3 : Removed support for nacl_interface_ext_supply of older interface versions #

Total comments: 2

Patch Set 4 : Moved size declaration down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -69 lines) Patch
M src/untrusted/nacl/nacl_ext_supply.c View 1 2 3 chunks +7 lines, -26 lines 0 comments Download
M tests/irt_ext/file_desc.c View 1 2 3 3 chunks +7 lines, -24 lines 0 comments Download
D tests/irt_ext/libc/file_tests.h View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/irt_ext/libc/file_tests.c View 1 chunk +1 line, -1 line 0 comments Download
A tests/irt_ext/libc/libc_test.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tests/irt_ext/libc/libc_test.c View 2 chunks +4 lines, -1 line 0 comments Download
A tests/irt_ext/libc/mem_tests.c View 1 1 chunk +80 lines, -0 lines 0 comments Download
A tests/irt_ext/mem_calls.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A tests/irt_ext/mem_calls.c View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
M tests/irt_ext/nacl.scons View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
David Yen
6 years, 3 months ago (2014-08-28 19:16:51 UTC) #1
Roland McGrath
LGTM https://codereview.chromium.org/511253005/diff/40001/tests/irt_ext/file_desc.c File tests/irt_ext/file_desc.c (right): https://codereview.chromium.org/511253005/diff/40001/tests/irt_ext/file_desc.c#newcode282 tests/irt_ext/file_desc.c:282: size_t size; Use C99 style rather than predeclaring ...
6 years, 3 months ago (2014-08-28 23:27:42 UTC) #2
David Yen
https://codereview.chromium.org/511253005/diff/40001/tests/irt_ext/file_desc.c File tests/irt_ext/file_desc.c (right): https://codereview.chromium.org/511253005/diff/40001/tests/irt_ext/file_desc.c#newcode282 tests/irt_ext/file_desc.c:282: size_t size; On 2014/08/28 23:27:42, Roland McGrath wrote: > ...
6 years, 3 months ago (2014-08-29 16:43:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/dyen@chromium.org/511253005/60001
6 years, 3 months ago (2014-08-29 16:49:02 UTC) #5
David Yen
6 years, 3 months ago (2014-08-29 21:21:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 13682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698