Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: Tools/GardeningServer/model/ct-failures.html

Issue 511253004: Use failure.tree field provided by the builder_alerts generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/model/test/ct-failures-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/model/ct-failures.html
diff --git a/Tools/GardeningServer/model/ct-failures.html b/Tools/GardeningServer/model/ct-failures.html
index 580f29588c68726dda54a94f05677357aa039ed5..f2327597c77fef98b5deb842af7b7317c608133c 100644
--- a/Tools/GardeningServer/model/ct-failures.html
+++ b/Tools/GardeningServer/model/ct-failures.html
@@ -20,24 +20,6 @@ function CTFailures(commitLog) {
// Maps a tree id to an array of CTFailureGroups within that tree.
this.failures = null;
this.lastUpdateDate = null;
-
- // FIXME: Get this from
- // https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/gatekeeper_trees.json?format=text.
- this._trees = {
- blink: [
- "https://build.chromium.org/p/chromium.webkit",
- ],
- chromium: [
- "https://build.chromium.org/p/chromium",
- "https://build.chromium.org/p/chromium.chrome",
- "https://build.chromium.org/p/chromium.chromiumos",
- "https://build.chromium.org/p/chromium.gpu",
- "https://build.chromium.org/p/chromium.linux",
- "https://build.chromium.org/p/chromium.mac",
- "https://build.chromium.org/p/chromium.memory",
- "https://build.chromium.org/p/chromium.win"
- ],
- };
}
(function() {
@@ -86,13 +68,6 @@ CTFailures.prototype._failureByTreeListComparator = function(tree, a, b) {
// Updates the format of the alerts array to be easier to parse.
CTFailures.prototype._mungeAlerts = function(alerts) {
- var masterToTree = {};
- Object.keys(this._trees, function(tree, masters) {
- masters.forEach(function(master) {
- masterToTree[master] = tree;
- });
- });
-
alerts.forEach(function(failure) {
// FIXME: Have the server store the actual failure type in a different
// field instead of smashing it into the reason.
@@ -107,10 +82,6 @@ CTFailures.prototype._mungeAlerts = function(alerts) {
failure.failureType = 'UNKNOWN';
}
}
-
- // FIXME: Figure out what tree masters that aren't in masterToTree
- // we should have.
- failure.tree = masterToTree[failure.master_url];
});
};
« no previous file with comments | « no previous file | Tools/GardeningServer/model/test/ct-failures-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698