sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java - Issue 511253002: Use name() instead of toString() and fix comparison order in ModelType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java

Issue 511253002: Use name() instead of toString() and fix comparison order in ModelType. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java

diff --git a/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java b/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java

index 714c3751edfc9fff5ed76614829c902c3c87525f..e7aa516006698e8df0f7b35560ae8eba138fdfbe 100644

--- a/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java

+++ b/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java

@@ -90,7 +90,7 @@ public enum ModelType {

private final boolean mNonInvalidationType;

ModelType(String modelType, boolean nonInvalidationType) {

- assert nonInvalidationType || modelType.equals(toString());

+ assert nonInvalidationType || name().equals(modelType);

mModelType = modelType;

mNonInvalidationType = nonInvalidationType;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »