Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 51123003: VM: Fix checked mode crash (issue 13831). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
11 #include "vm/compiler.h" 11 #include "vm/compiler.h"
12 #include "vm/dart_entry.h" 12 #include "vm/dart_entry.h"
13 #include "vm/deopt_instructions.h" 13 #include "vm/deopt_instructions.h"
14 #include "vm/il_printer.h" 14 #include "vm/il_printer.h"
15 #include "vm/locations.h" 15 #include "vm/locations.h"
16 #include "vm/object_store.h" 16 #include "vm/object_store.h"
17 #include "vm/parser.h" 17 #include "vm/parser.h"
18 #include "vm/stack_frame.h" 18 #include "vm/stack_frame.h"
19 #include "vm/stub_code.h" 19 #include "vm/stub_code.h"
20 #include "vm/symbols.h" 20 #include "vm/symbols.h"
21 21
22 namespace dart { 22 namespace dart {
23 23
24 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization."); 24 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
25 DEFINE_FLAG(bool, unbox_mints, true, "Optimize 64-bit integer arithmetic."); 25 DEFINE_FLAG(bool, unbox_mints, true, "Optimize 64-bit integer arithmetic.");
26 DECLARE_FLAG(int, optimization_counter_threshold); 26 DECLARE_FLAG(int, optimization_counter_threshold);
27 DECLARE_FLAG(int, reoptimization_counter_threshold); 27 DECLARE_FLAG(int, reoptimization_counter_threshold);
28 DECLARE_FLAG(bool, print_ast);
29 DECLARE_FLAG(bool, print_scopes);
30 DECLARE_FLAG(bool, enable_type_checks); 28 DECLARE_FLAG(bool, enable_type_checks);
31 DECLARE_FLAG(bool, eliminate_type_checks); 29 DECLARE_FLAG(bool, eliminate_type_checks);
32 DECLARE_FLAG(bool, throw_on_javascript_int_overflow); 30 DECLARE_FLAG(bool, throw_on_javascript_int_overflow);
33 31
34 32
35 FlowGraphCompiler::~FlowGraphCompiler() { 33 FlowGraphCompiler::~FlowGraphCompiler() {
36 // BlockInfos are zone-allocated, so their destructors are not called. 34 // BlockInfos are zone-allocated, so their destructors are not called.
37 // Verify the labels explicitly here. 35 // Verify the labels explicitly here.
38 for (int i = 0; i < block_info_.length(); ++i) { 36 for (int i = 0; i < block_info_.length(); ++i) {
39 ASSERT(!block_info_[i]->jump_label()->IsLinked()); 37 ASSERT(!block_info_[i]->jump_label()->IsLinked());
(...skipping 1123 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 const intptr_t slot_base = parsed_function().first_stack_local_index(); 1161 const intptr_t slot_base = parsed_function().first_stack_local_index();
1164 const Immediate& raw_null = 1162 const Immediate& raw_null =
1165 Immediate(reinterpret_cast<intptr_t>(Object::null())); 1163 Immediate(reinterpret_cast<intptr_t>(Object::null()));
1166 __ movl(EAX, raw_null); 1164 __ movl(EAX, raw_null);
1167 for (intptr_t i = 0; i < num_locals; ++i) { 1165 for (intptr_t i = 0; i < num_locals; ++i) {
1168 // Subtract index i (locals lie at lower addresses than EBP). 1166 // Subtract index i (locals lie at lower addresses than EBP).
1169 __ movl(Address(EBP, (slot_base - i) * kWordSize), EAX); 1167 __ movl(Address(EBP, (slot_base - i) * kWordSize), EAX);
1170 } 1168 }
1171 } 1169 }
1172 1170
1173 if (FLAG_print_scopes) {
1174 // Print the function scope (again) after generating the prologue in order
1175 // to see annotations such as allocation indices of locals.
1176 if (FLAG_print_ast) {
1177 // Second printing.
1178 OS::Print("Annotated ");
1179 }
1180 AstPrinter::PrintFunctionScope(parsed_function());
1181 }
1182
1183 ASSERT(!block_order().is_empty()); 1171 ASSERT(!block_order().is_empty());
1184 VisitBlocks(); 1172 VisitBlocks();
1185 1173
1186 __ int3(); 1174 __ int3();
1187 GenerateDeferredCode(); 1175 GenerateDeferredCode();
1188 // Emit function patching code. This will be swapped with the first 5 bytes 1176 // Emit function patching code. This will be swapped with the first 5 bytes
1189 // at entry point. 1177 // at entry point.
1190 AddCurrentDescriptor(PcDescriptors::kPatchCode, 1178 AddCurrentDescriptor(PcDescriptors::kPatchCode,
1191 Isolate::kNoDeoptId, 1179 Isolate::kNoDeoptId,
1192 0); // No token position. 1180 0); // No token position.
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 __ movups(reg, Address(ESP, 0)); 1907 __ movups(reg, Address(ESP, 0));
1920 __ addl(ESP, Immediate(kFpuRegisterSize)); 1908 __ addl(ESP, Immediate(kFpuRegisterSize));
1921 } 1909 }
1922 1910
1923 1911
1924 #undef __ 1912 #undef __
1925 1913
1926 } // namespace dart 1914 } // namespace dart
1927 1915
1928 #endif // defined TARGET_ARCH_IA32 1916 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698