Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 51123003: VM: Fix checked mode crash (issue 13831). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
11 #include "vm/compiler.h" 11 #include "vm/compiler.h"
12 #include "vm/dart_entry.h" 12 #include "vm/dart_entry.h"
13 #include "vm/deopt_instructions.h" 13 #include "vm/deopt_instructions.h"
14 #include "vm/il_printer.h" 14 #include "vm/il_printer.h"
15 #include "vm/locations.h" 15 #include "vm/locations.h"
16 #include "vm/object_store.h" 16 #include "vm/object_store.h"
17 #include "vm/parser.h" 17 #include "vm/parser.h"
18 #include "vm/stack_frame.h" 18 #include "vm/stack_frame.h"
19 #include "vm/stub_code.h" 19 #include "vm/stub_code.h"
20 #include "vm/symbols.h" 20 #include "vm/symbols.h"
21 21
22 namespace dart { 22 namespace dart {
23 23
24 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization."); 24 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
25 DECLARE_FLAG(int, optimization_counter_threshold); 25 DECLARE_FLAG(int, optimization_counter_threshold);
26 DECLARE_FLAG(int, reoptimization_counter_threshold); 26 DECLARE_FLAG(int, reoptimization_counter_threshold);
27 DECLARE_FLAG(bool, print_ast);
28 DECLARE_FLAG(bool, print_scopes);
29 DECLARE_FLAG(bool, enable_type_checks); 27 DECLARE_FLAG(bool, enable_type_checks);
30 DECLARE_FLAG(bool, eliminate_type_checks); 28 DECLARE_FLAG(bool, eliminate_type_checks);
31 29
32 30
33 FlowGraphCompiler::~FlowGraphCompiler() { 31 FlowGraphCompiler::~FlowGraphCompiler() {
34 // BlockInfos are zone-allocated, so their destructors are not called. 32 // BlockInfos are zone-allocated, so their destructors are not called.
35 // Verify the labels explicitly here. 33 // Verify the labels explicitly here.
36 for (int i = 0; i < block_info_.length(); ++i) { 34 for (int i = 0; i < block_info_.length(); ++i) {
37 ASSERT(!block_info_[i]->jump_label()->IsLinked()); 35 ASSERT(!block_info_[i]->jump_label()->IsLinked());
38 ASSERT(!block_info_[i]->jump_label()->HasNear()); 36 ASSERT(!block_info_[i]->jump_label()->HasNear());
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1203 if (!is_optimizing() && (num_locals > 0)) { 1201 if (!is_optimizing() && (num_locals > 0)) {
1204 __ Comment("Initialize spill slots"); 1202 __ Comment("Initialize spill slots");
1205 const intptr_t slot_base = parsed_function().first_stack_local_index(); 1203 const intptr_t slot_base = parsed_function().first_stack_local_index();
1206 __ LoadObject(RAX, Object::null_object(), PP); 1204 __ LoadObject(RAX, Object::null_object(), PP);
1207 for (intptr_t i = 0; i < num_locals; ++i) { 1205 for (intptr_t i = 0; i < num_locals; ++i) {
1208 // Subtract index i (locals lie at lower addresses than RBP). 1206 // Subtract index i (locals lie at lower addresses than RBP).
1209 __ movq(Address(RBP, (slot_base - i) * kWordSize), RAX); 1207 __ movq(Address(RBP, (slot_base - i) * kWordSize), RAX);
1210 } 1208 }
1211 } 1209 }
1212 1210
1213 if (FLAG_print_scopes) {
1214 // Print the function scope (again) after generating the prologue in order
1215 // to see annotations such as allocation indices of locals.
1216 if (FLAG_print_ast) {
1217 // Second printing.
1218 OS::Print("Annotated ");
1219 }
1220 AstPrinter::PrintFunctionScope(parsed_function());
1221 }
1222
1223 ASSERT(!block_order().is_empty()); 1211 ASSERT(!block_order().is_empty());
1224 VisitBlocks(); 1212 VisitBlocks();
1225 1213
1226 __ int3(); 1214 __ int3();
1227 GenerateDeferredCode(); 1215 GenerateDeferredCode();
1228 // Emit function patching code. This will be swapped with the first 13 bytes 1216 // Emit function patching code. This will be swapped with the first 13 bytes
1229 // at entry point. 1217 // at entry point.
1230 AddCurrentDescriptor(PcDescriptors::kPatchCode, 1218 AddCurrentDescriptor(PcDescriptors::kPatchCode,
1231 Isolate::kNoDeoptId, 1219 Isolate::kNoDeoptId,
1232 0); // No token position. 1220 0); // No token position.
(...skipping 714 matching lines...) Expand 10 before | Expand all | Expand 10 after
1947 __ movups(reg, Address(RSP, 0)); 1935 __ movups(reg, Address(RSP, 0));
1948 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP); 1936 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP);
1949 } 1937 }
1950 1938
1951 1939
1952 #undef __ 1940 #undef __
1953 1941
1954 } // namespace dart 1942 } // namespace dart
1955 1943
1956 #endif // defined TARGET_ARCH_X64 1944 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698