Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 511223002: Update some paths from components/breakpad/ to components/crash/ (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update some paths from components/breakpad/ to components/crash/ It was moved in https://crrev.com/55b8563 Found by git grep 'components.*breakpad' BUG=406410 R=rsesek@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/3f9d5bde7371956af8a9c70e52aa899847db6a5f Cr-Commit-Position: refs/heads/master@{#292376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/breakpad_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
PTAL
6 years, 3 months ago (2014-08-28 13:11:36 UTC) #1
Robert Sesek
LGTM, thanks. I can see why grepping didn't match some of those.
6 years, 3 months ago (2014-08-28 13:24:48 UTC) #2
philipj_slow
Yeah, the one in PRESUBMIT_test.py was probably just a fluke. Do you happen to have ...
6 years, 3 months ago (2014-08-28 13:30:16 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 3 months ago (2014-08-28 13:30:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/511223002/1
6 years, 3 months ago (2014-08-28 13:31:16 UTC) #5
Robert Sesek
On 2014/08/28 13:30:16, philipj wrote: > Yeah, the one in PRESUBMIT_test.py was probably just a ...
6 years, 3 months ago (2014-08-28 13:32:07 UTC) #6
philipj_slow
On 2014/08/28 13:32:07, rsesek wrote: > On 2014/08/28 13:30:16, philipj wrote: > > Yeah, the ...
6 years, 3 months ago (2014-08-28 13:51:14 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 14:03:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as cd820de501b9f598a4bddfe30f28527147c1a460
6 years, 3 months ago (2014-08-28 14:09:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f9d5bde7371956af8a9c70e52aa899847db6a5f
Cr-Commit-Position: refs/heads/master@{#292376}

Powered by Google App Engine
This is Rietveld 408576698