Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 511213002: Remove duplicated code in for loop in VideoCapture on Windows (Closed)

Created:
6 years, 3 months ago by magjed_chromium
Modified:
6 years, 3 months ago
Reviewers:
perkj_chrome, mcasas
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated code in for loop in VideoCapture on Windows Committed: https://crrev.com/4405bc45f47567c3f0e36c0ad18f9db192f86850 Cr-Commit-Position: refs/heads/master@{#292623}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mcasas@s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M media/video/capture/win/video_capture_device_factory_win.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
magjed_chromium
magjed@chromium.org changed reviewers: + mcasas@chromium.org, perkj@chromium.org
6 years, 3 months ago (2014-08-28 13:00:10 UTC) #1
magjed_chromium
PTAL
6 years, 3 months ago (2014-08-28 13:04:04 UTC) #2
mcasas
LGTM % my comment. https://codereview.chromium.org/511213002/diff/1/media/video/capture/win/video_capture_device_factory_win.cc File media/video/capture/win/video_capture_device_factory_win.cc (right): https://codereview.chromium.org/511213002/diff/1/media/video/capture/win/video_capture_device_factory_win.cc#newcode302 media/video/capture/win/video_capture_device_factory_win.cc:302: while (SUCCEEDED(hr = reader->GetNativeMediaType( remove ...
6 years, 3 months ago (2014-08-28 16:48:27 UTC) #3
magjed_chromium
https://codereview.chromium.org/511213002/diff/1/media/video/capture/win/video_capture_device_factory_win.cc File media/video/capture/win/video_capture_device_factory_win.cc (right): https://codereview.chromium.org/511213002/diff/1/media/video/capture/win/video_capture_device_factory_win.cc#newcode302 media/video/capture/win/video_capture_device_factory_win.cc:302: while (SUCCEEDED(hr = reader->GetNativeMediaType( On 2014/08/28 16:48:27, mcasas wrote: ...
6 years, 3 months ago (2014-08-28 17:00:55 UTC) #4
perkj_chrome
lgtm
6 years, 3 months ago (2014-08-29 08:39:29 UTC) #5
perkj_chrome
On 2014/08/29 08:39:29, perkj wrote: > lgtm please remove the BUG= if it does not ...
6 years, 3 months ago (2014-08-29 08:39:55 UTC) #6
magjed_chromium
The CQ bit was checked by magjed@chromium.org
6 years, 3 months ago (2014-08-29 09:16:32 UTC) #7
magjed_chromium
The CQ bit was unchecked by magjed@chromium.org
6 years, 3 months ago (2014-08-29 09:16:35 UTC) #8
magjed_chromium
The CQ bit was checked by magjed@chromium.org
6 years, 3 months ago (2014-08-29 09:16:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/magjed@chromium.org/511213002/20001
6 years, 3 months ago (2014-08-29 09:17:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 97727077298382904b2ffadb220da7dd77b1e17a
6 years, 3 months ago (2014-08-29 13:56:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:18 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4405bc45f47567c3f0e36c0ad18f9db192f86850
Cr-Commit-Position: refs/heads/master@{#292623}

Powered by Google App Engine
This is Rietveld 408576698