Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 511173002: Manual fixups for scoped_refptr operator T* removal in sync/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
rlarocque, Nicolas Zea
CC:
chromium-reviews, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups for scoped_refptr operator T* removal in sync/ BUG=110610 Committed: https://crrev.com/52f7cef756798c453c1da702ba824133af195bfa Cr-Commit-Position: refs/heads/master@{#292514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M sync/internal_api/http_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/http_bridge_network_resources.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/http_bridge_network_resources.h View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/network_resources.h View 1 chunk +2 lines, -1 line 0 comments Download
M sync/test/fake_server/fake_server_network_resources.h View 1 chunk +6 lines, -5 lines 0 comments Download
M sync/test/fake_server/fake_server_network_resources.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + rlarocque@chromium.org
6 years, 3 months ago (2014-08-28 09:40:43 UTC) #1
dcheng
These are manual fixups for the cases the automated conversion tool skipped. I've converted methods ...
6 years, 3 months ago (2014-08-28 09:40:43 UTC) #2
rlarocque
rlarocque@chromium.org changed reviewers: + zea@chromium.org
6 years, 3 months ago (2014-08-28 17:05:01 UTC) #3
rlarocque
I'm no longer on the Chrome team, so you're more likely to get quick responses ...
6 years, 3 months ago (2014-08-28 17:05:01 UTC) #4
Nicolas Zea
lgtm
6 years, 3 months ago (2014-08-28 23:05:15 UTC) #5
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 23:05:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/511173002/1
6 years, 3 months ago (2014-08-28 23:06:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 659020af8829ea6340249ab352340c4d7df91252
6 years, 3 months ago (2014-08-29 00:08:49 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52f7cef756798c453c1da702ba824133af195bfa
Cr-Commit-Position: refs/heads/master@{#292514}

Powered by Google App Engine
This is Rietveld 408576698