Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: net/disk_cache/simple/simple_backend_impl.cc

Issue 511163002: Net-related fixups for scoped_refptr conversion operator cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix naming to match Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_backend_impl.h ('k') | net/disk_cache/simple/simple_index.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_backend_impl.cc
diff --git a/net/disk_cache/simple/simple_backend_impl.cc b/net/disk_cache/simple/simple_backend_impl.cc
index c92a93a7114406d7003290d8b5ae55019d36502e..04329e4364853fe9f20e947d659bd6895c3203c3 100644
--- a/net/disk_cache/simple/simple_backend_impl.cc
+++ b/net/disk_cache/simple/simple_backend_impl.cc
@@ -656,7 +656,7 @@ void SimpleBackendImpl::GetNextEntryInIterator(
void SimpleBackendImpl::OnEntryOpenedFromHash(
uint64 hash,
Entry** entry,
- scoped_refptr<SimpleEntryImpl> simple_entry,
+ const scoped_refptr<SimpleEntryImpl>& simple_entry,
const CompletionCallback& callback,
int error_code) {
if (error_code != net::OK) {
@@ -665,7 +665,7 @@ void SimpleBackendImpl::OnEntryOpenedFromHash(
}
DCHECK(*entry);
std::pair<EntryMap::iterator, bool> insert_result =
- active_entries_.insert(EntryMap::value_type(hash, simple_entry));
+ active_entries_.insert(EntryMap::value_type(hash, simple_entry.get()));
EntryMap::iterator& it = insert_result.first;
const bool did_insert = insert_result.second;
if (did_insert) {
@@ -686,7 +686,7 @@ void SimpleBackendImpl::OnEntryOpenedFromHash(
void SimpleBackendImpl::OnEntryOpenedFromKey(
const std::string key,
Entry** entry,
- scoped_refptr<SimpleEntryImpl> simple_entry,
+ const scoped_refptr<SimpleEntryImpl>& simple_entry,
const CompletionCallback& callback,
int error_code) {
int final_code = error_code;
« no previous file with comments | « net/disk_cache/simple/simple_backend_impl.h ('k') | net/disk_cache/simple/simple_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698