Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.cc

Issue 511163002: Net-related fixups for scoped_refptr conversion operator cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ssl_client_certificate_selector.cc
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
index 4a96ca97f5632bae9e74641b8a0461e85b907f3c..2e313449ff5a651c578a2355120efea76b4b1ea5 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
@@ -83,10 +83,10 @@ void CertificateSelectorTableModel::SetObserver(
SSLClientCertificateSelector::SSLClientCertificateSelector(
content::WebContents* web_contents,
const net::HttpNetworkSession* network_session,
- net::SSLCertRequestInfo* cert_request_info,
+ const scoped_refptr<net::SSLCertRequestInfo>& cert_request_info,
const chrome::SelectCertificateCallback& callback)
: SSLClientAuthObserver(network_session, cert_request_info, callback),
- model_(new CertificateSelectorTableModel(cert_request_info)),
+ model_(new CertificateSelectorTableModel(cert_request_info.get())),
mmenke 2014/08/28 13:47:32 We aren't holding onto a pointer to cert_request_i
dcheng 2014/08/28 16:23:15 This class doesn't, but its base class (SSLClientA
web_contents_(web_contents),
table_(NULL),
view_cert_button_(NULL) {

Powered by Google App Engine
This is Rietveld 408576698