Manual fixups for scoped_refptr operator T* removal in base/

Manual fixups for scoped_refptr operator T* removal in base/

BUG=110610
Committed: https://crrev.com/077d1b2059778413e7b10db4fe9f248370136edd
Cr-Commit-Position: refs/heads/master@{#292429}

[dcheng, 2014-08-28 09:13:38]

dcheng@chromium.org changed reviewers:
+ willchan@chromium.org

[dcheng, 2014-08-28 09:13:38]

These are manual fixups I applied after running the tooling over Chrome. It
revealed a lot of instances of a refcounted object being turned into a raw
pointer and then immediately copied into a scoped_refptr. I've opted to pass
those as const scoped_refptr<T>& instead to give a signal that the functions in
question will result in taking a ref to the object.

Unfortunately, since scoped_refptr<T> is implicitly constructible from T*, I'll
have to run a separate pass afterwards to cleanup instances where a
scoped_refptr<> is turned into a T* before being passed into a const
scoped_refptr<T>&.

[gab, 2014-08-28 11:52:24]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2014-08-28 11:52:24]

lgtm w/ follow-up pass to cleanup callers that do (which I believe is also what
you said):

class TakesAFooRef {
 public:
  TakesAFooRef(const scoped_refptr<Foo>& foo)
      : foo_(foo);

 private:
  scoped_refptr<Foo> foo_;
};

scoped_refptr<Foo> foo;
TakesAFooRef(foo.get()); // i.e. no need for .get() here since constructor
                         // takes a const scoped_refptr<Foo>&

[willchan no longer on Chromium, 2014-08-28 17:28:48]

lgtm

[dcheng, 2014-08-28 17:29:29]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:30:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/511153002/1

[commit-bot: I haz the power, 2014-08-28 17:57:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-28 18:48:07]

Committed patchset #1 (id:1) as e0e8304302cef12e878b0b28a67f8cb7cddbb87f

[commit-bot: I haz the power, 2014-09-10 03:01:06]

Patchset 1 (id:??) landed as
https://crrev.com/077d1b2059778413e7b10db4fe9f248370136edd
Cr-Commit-Position: refs/heads/master@{#292429}