Issue 511133002: Fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511133002: Fix build. (Closed)

Created:
6 years, 3 months ago by sigurds

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix build. GCC needs definitions for constant members (clang doesn't). TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23480

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	test/cctest/compiler/function-tester.h	View		1 chunk	+2 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sigurds

Committed patchset #1 manually as 23480 (tree was closed).

6 years, 3 months ago (2014-08-28 08:47:20 UTC) #1

Sven Panne

svenpanne@chromium.org changed reviewers: + svenpanne@chromium.org

6 years, 3 months ago (2014-08-28 08:53:13 UTC) #2

Sven Panne

https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (left): https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h#oldcode28 test/cctest/compiler/function-tester.h:28: const uint32_t supported_flags = I don't really think that ...

6 years, 3 months ago (2014-08-28 08:53:13 UTC) #3

sigurds

6 years, 3 months ago (2014-08-28 09:25:44 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/functio...
File test/cctest/compiler/function-tester.h (left):

https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/functio...
test/cctest/compiler/function-tester.h:28: const uint32_t supported_flags =
On 2014/08/28 08:53:13, Sven Panne wrote:
> I don't really think that you wanted to define an immutable member field here,
> anyway... :-)
Yes, it should have been static.

Expand Messages | Collapse Messages