chrome/browser/extensions/webstore_data_fetcher.cc - Issue 51113014: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_data_fetcher.cc

Issue 51113014: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reupload Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_data.cc ('k') | chrome/browser/extensions/webstore_data_fetcher_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_data_fetcher.cc

diff --git a/chrome/browser/extensions/webstore_data_fetcher.cc b/chrome/browser/extensions/webstore_data_fetcher.cc

index 5d5e5254688870614f85c34d14d0ab91c2759d58..89d523b8135dc93f80fecf59adce350bffb011d3 100644

--- a/chrome/browser/extensions/webstore_data_fetcher.cc

+++ b/chrome/browser/extensions/webstore_data_fetcher.cc

@@ -53,8 +53,8 @@ void WebstoreDataFetcher::OnJsonParseSuccess(

return;

}

- delegate_->OnWebstoreResponseParseSuccess(

- static_cast<base::DictionaryValue*>(parsed_json.release()));

+ delegate_->OnWebstoreResponseParseSuccess(scoped_ptr<base::DictionaryValue>(

+ static_cast<base::DictionaryValue*>(parsed_json.release())));

benwells 2013/11/01 06:01:01 fun times :)

}

void WebstoreDataFetcher::OnJsonParseFailure(

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_data.cc ('k') | chrome/browser/extensions/webstore_data_fetcher_delegate.h » ('j') | no next file with comments »