Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 51113009: Linux: add a Credentials class to handle Linux capabilities. (Closed)

Created:
7 years, 1 month ago by jln (very slow on Chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux: add a Credentials class to handle Linux capabilities. BUG=312380 R=jorgelo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232280

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
M sandbox/linux/sandbox_linux.gypi View 2 chunks +14 lines, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
A sandbox/linux/services/credentials.h View 1 chunk +46 lines, -0 lines 0 comments Download
A sandbox/linux/services/credentials.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
A sandbox/linux/services/credentials_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Jorge: please, take a look! (This needs to wait until the infrastructure is updated with ...
7 years, 1 month ago (2013-10-31 01:11:54 UTC) #1
Jorge Lucangeli Obes
https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h File sandbox/linux/services/credentials.h (right): https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h#newcode34 sandbox/linux/services/credentials.h:34: bool HasAnyCapability(); Does your PoC use the API like ...
7 years, 1 month ago (2013-10-31 20:55:32 UTC) #2
jln (very slow on Chromium)
https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h File sandbox/linux/services/credentials.h (right): https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h#newcode34 sandbox/linux/services/credentials.h:34: bool HasAnyCapability(); On 2013/10/31 20:55:32, Jorge Lucangeli Obes wrote: ...
7 years, 1 month ago (2013-10-31 21:02:22 UTC) #3
Jorge Lucangeli Obes
On 2013/10/31 21:02:22, jln wrote: > https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h > File sandbox/linux/services/credentials.h (right): > > https://codereview.chromium.org/51113009/diff/1/sandbox/linux/services/credentials.h#newcode34 > ...
7 years, 1 month ago (2013-10-31 21:04:30 UTC) #4
jln (very slow on Chromium)
Committed patchset #2 manually as r232280.
7 years, 1 month ago (2013-11-01 02:33:39 UTC) #5
jln (very slow on Chromium)
7 years, 1 month ago (2013-11-01 02:56:27 UTC) #6
Message was sent while issue was closed.
Broke a bunch of bots that still didn't have libcap-dev, reverted :(

Powered by Google App Engine
This is Rietveld 408576698